Update wrapper of xprs.h

[odow]

I need to figure out a good way of handling the variety of Xpress versions that people might use.

I have headers for v33.01.12 and v42.01.05. Ideally, the Xpress.jl should use only functions defined in v33, but it should provide constants etc for v42.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.93%. Comparing base (5eb8119) to head (209c78b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   67.91%   67.93%   +0.01%     
==========================================
  Files           6        6              
  Lines        3301     3303       +2     
==========================================
+ Hits         2242     2244       +2     
  Misses       1059     1059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odow]

So I found one super weird thing here. The xprs.jl uses Cint in places where it should use Clong. They are equivalent on windows, but not on Mac or Linux. I don't know if this causes any issues because we don't call the 64( API.

[odow]

Okay. I've hacked around to get the right Cstring and Ptr{UInt8} in the right places. Focusing on minimal changes. We can reconsider in a different PR.

[odow]

I think this really highlights that we should have some way of testing v8

[odow]

x-ref JuliaRegistries/General#103626

[odow]

These bits were nasty:

Xpress.jl/src/Lib/xprs.jl

Lines 2366 to 2394 in ceb9df8

	function _getversion()
	buffer = Array{Cchar}(undef, 8 * 24)
	buffer_p = pointer(buffer)
	GC.@preserve buffer begin
	out = Cstring(buffer_p)
	r = Lib.XPRSgetversion(out)
	if r != 0
	throw(XpressError(r, "Unable to invoke XPRSgetversion"))
	end
	version = unsafe_string(out)::String
	end
	return VersionNumber(parse.(Int, split(version, "."))...)
	end
	function XPRSgetglobal(prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	if _getversion() >= v"41.0.0"
	return ccall((:XPRSgetmipentities, libxprs), Cint, (XPRSprob, Ptr{Cint}, Ptr{Cint}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cdouble}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cint}, Ptr{Cdouble}), prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	else
	return ccall((:XPRSgetglobal, libxprs), Cint, (XPRSprob, Ptr{Cint}, Ptr{Cint}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cdouble}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cint}, Ptr{Cdouble}), prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	end
	end
	function XPRSgetglobal64(prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	if _getversion() >= v"41.0.0"
	return ccall((:XPRSgetmipentities64, libxprs), Cint, (XPRSprob, Ptr{Cint}, Ptr{Cint}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cdouble}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cint}, Ptr{Cdouble}), prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	else
	return ccall((:XPRSgetglobal64, libxprs), Cint, (XPRSprob, Ptr{Cint}, Ptr{Cint}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cdouble}, Ptr{UInt8}, Ptr{Cint}, Ptr{Cint}, Ptr{Cdouble}), prob, p_nentities, p_nsets, coltype, colind, limit, settype, start, setcols, refval)
	end
	end

[odow]

Okay. I'm feeling a lot better about this now that we're testing on v8 and v9.

[odow]

Merging because I want to open a couple of follow-ups.