Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to a discussion on whether this should be v0.16.3 or v0.17.0.
The argument for v0.17.0 is that it is a rather large change: v0.16.2...master
The main breakage risks are #257 and #259.
64(
functions inLib
(but they were probably already broken because of the wrong type?)Xpress.jl/src/Lib/xprs.jl
Lines 2366 to 2394 in ceb9df8
XPRSgetmipentities
orXPRSgetglobal
, but this shouldn affect only people hacking at the C API.I've also moved a bunch of unused stuff to
src/api.jl
which was never tested, so there's a risk I made a mistake during the refactoring that wasn't caught because of the lack of tests.TODO