Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/deprecate CreateMeABus and JustSayingFluently* #471

Closed
martincostello opened this issue Dec 13, 2018 · 11 comments · Fixed by #749
Closed

Remove/deprecate CreateMeABus and JustSayingFluently* #471

martincostello opened this issue Dec 13, 2018 · 11 comments · Fixed by #749
Assignees
Milestone

Comments

@martincostello
Copy link
Member

Now that #431 has been merged which provides the basis for a new "builder API" for using JustSaying, which should start work on slowly deprecating the existing CreatMeABus class in master so that by the time we release 7.0.0 it no longer exists, as well as removing the existing JustSayingFluently* classes.

@martincostello
Copy link
Member Author

Unless there are compelling reasons not to do so, the new API should have feature parity with the 6.x.x releases in the new API surface.

Feature parity in this sense means that you can achieve a comparable result, but it does not necessarily need to be like-for-like in terms of it being a default behaviour or not, naming or location in the API.

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 7, 2019
This was referenced Feb 24, 2019
@stale
Copy link

stale bot commented Apr 4, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 4, 2019
@stale
Copy link

stale bot commented May 30, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 30, 2019
@stale
Copy link

stale bot commented Jul 25, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2020
@stale
Copy link

stale bot commented Apr 8, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 8, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 11, 2020
@gkinsman
Copy link
Contributor

gkinsman commented Aug 5, 2020

@martincostello for V7, can we perhaps scope this issue to removing CreateMeABus while leaving JustSayingFluently? The new fluent API depends on it so we'd need to pass those calls straight through to the JustSayingBus if we wanted to rip out fluently too.

JustSayingStack bypasses it completely so we don't need to think about it much. We could also just make JustSayingFluently internal to hide it?

@martincostello
Copy link
Member Author

The original idea was to implement it on top of the old one just to get the new API in, and then after that hoist the implementation up (or move it) so that CMAB and JSF could be deleted.

If we want to not wait to do that for v7, I'd be happy to settle for making all of it internal so that it's effectively removed and then can be chipped-away at separately.

@gkinsman
Copy link
Contributor

gkinsman commented Aug 5, 2020

That sounds fair - I'm tempted to spike out removing it in the case that it is just a matter of passing the calls through to JSB, but I suspect it might be a little trickier than that. If that fails I'll make it internal 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants