-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/deprecate CreateMeABus and JustSayingFluently* #471
Comments
Unless there are compelling reasons not to do so, the new API should have feature parity with the Feature parity in this sense means that you can achieve a comparable result, but it does not necessarily need to be like-for-like in terms of it being a default behaviour or not, naming or location in the API. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@martincostello for V7, can we perhaps scope this issue to removing CreateMeABus while leaving JustSayingFluently? The new fluent API depends on it so we'd need to pass those calls straight through to the JustSayingBus if we wanted to rip out fluently too. JustSayingStack bypasses it completely so we don't need to think about it much. We could also just make JustSayingFluently internal to hide it? |
The original idea was to implement it on top of the old one just to get the new API in, and then after that hoist the implementation up (or move it) so that CMAB and JSF could be deleted. If we want to not wait to do that for v7, I'd be happy to settle for making all of it internal so that it's effectively removed and then can be chipped-away at separately. |
That sounds fair - I'm tempted to spike out removing it in the case that it is just a matter of passing the calls through to JSB, but I suspect it might be a little trickier than that. If that fails I'll make it internal 👍 |
Now that #431 has been merged which provides the basis for a new "builder API" for using JustSaying, which should start work on slowly deprecating the existing
CreatMeABus
class inmaster
so that by the time we release7.0.0
it no longer exists, as well as removing the existingJustSayingFluently*
classes.The text was updated successfully, but these errors were encountered: