Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WithMessageHandler<IHandlerAsync<T>> #624

Merged

Conversation

adammorr
Copy link
Contributor

@adammorr adammorr commented Dec 30, 2019

As mentioned in #484 and #471, this PR removes WithMessageHandler<IHandlerAsync<T>> as it hasn't been ported over to the new API and is not something we intend to do

@adammorr adammorr requested a review from a team as a code owner December 30, 2019 13:29
@ghost ghost requested a review from brainmurphy December 30, 2019 13:29
@adammorr adammorr removed the request for review from brainmurphy December 30, 2019 13:30
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #624 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   77.13%   77.31%   +0.18%     
==========================================
  Files          99       99              
  Lines        2519     2495      -24     
==========================================
- Hits         1943     1929      -14     
+ Misses        576      566      -10
Flag Coverage Δ
#linux 77.31% <ø> (+0.18%) ⬆️
#osx 43.8% <ø> (+0.65%) ⬆️
#windows 47.33% <ø> (+0.74%) ⬆️
Impacted Files Coverage Δ
src/JustSaying/JustSayingFluentlyExtensions.cs 81.81% <ø> (+21.81%) ⬆️
src/JustSaying/JustSayingFluently.cs 89.61% <ø> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5eac6...17d3790. Read the comment docs.

@adammorr adammorr merged commit 54dc067 into justeattakeaway:master Jan 2, 2020
@adammorr adammorr deleted the remove-withmessagehandler-overload branch January 2, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants