Migrate tests #521
Migrate tests #521
Conversation
Change integration test to a unit test because it was using mocks to simulate AWS behaviour, so was more of a unit test.
Delete integration test that is doing low-level asserts to verify call counts. This should be rewritten as a unit test at a later point if it's really important, which I don't think it is.
Migrate integration test for error queue away from XAsyncBehaviourTest.
Migrate AwsTools integration tests away from XAsyncBehaviourTest. Next step will be to refactor them to go via the fluent interface, rather than with the direct objects.
Move attribute to root of project.
Move the "global" setup as it is now only used for multi-region tests.
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 37.5% 37.86% +0.36%
==========================================
Files 78 78
Lines 2608 2609 +1
Branches 453 453
==========================================
+ Hits 978 988 +10
+ Misses 1492 1481 -11
- Partials 138 140 +2
Continue to review full report at Codecov.
|
|
Hard to review, since there are a lots of files and they don't match up - name, folder and contents have all changed so git can't tell which new one matches which old one. |
|
All I can suggest is review one commit at a time - they're a rewrite, so they won't align, and the styles are fundamentally different anyway. Alternatively, I can cherry pick each commit into a different PR each, but that's basically the same as looking at the diffs in each commit, except split over 6 PRs instead of one. |
JustSaying.IntegrationTests/Fluent/AwsTools/WhenCreatingErrorQueue.cs
Outdated
Show resolved
Hide resolved
Update the name of a test to reduce confusion.
As part of #380 (and eventually #471), this PR migrates some of the "old style" integration tests to the "newer way" of doing our integration tests.
These tests still use the queue classes directly in an integration-y way, but after this is merged I'll migrate them to setup via the fluent API so they're less "low-level".
The only "old" integration tests left now are the multi-region ones, which need a real AWS account to refactor them against as the emulator doesn't really support multi-region.