-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make integration test fully async #426
Make integration test fully async #426
Conversation
There’s been a few seemingly massive diffs in other PRs due to line endings too. I guess we’re in need of a .gitattributes fix to ensure we’re not at the mercy of people’s local settings? |
Hm, we have a |
679e544
to
7b9f7e1
Compare
Because we were hitting the fluent api code (that blocks) previously in the constructor, it was "harmless". Now we are using async initialization, we deadlock the xunit SynchronizationContext. |
@slang25 I noticed you have an old |
I'd like to keep it for reference, I'll move it into my fork and delete it from this repo |
Any progress on a JustBehave release? |
@slang25 https://www.nuget.org/packages/JustBehave/2.0.0-beta-62 will be a thing once NuGet updates |
Thanks @adammorr ! |
f9ba2ff
to
72b0aee
Compare
I’ll review this tomorrow 👍🏻 |
Thanks, it's pretty boring I'm afraid! |
08b2b88
to
a915200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor points but otherwise, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at the failure over lunch |
I've put the tests back to running sequentially now, there are too many areas that require exclusivity. Ready now @martincostello |
Go go gadget tests! |
Attempt to kill almost all blocking code, this removes all the occurences in the test projects. There are only 2 places left now:
Thottled.cs, this one is tricky and could be hit under contention when at throttling limits, I have an idea on how to fix this in a non-breaking way. For another PR.Something is going on with line-endings, I don't know if it's me, or if the code base needs all lines normalizing. I'll investigate.