Normalize line endings #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammorr
previously approved these changes
Nov 20, 2018
|
Yep https://github.com/justeat/JustSaying/pull/441/files?w=1 Pro-tip: don't open the regular diff on your phone |
slang25
force-pushed
the
line-endings
branch
from
0bd2f83 to
c8495a1
Compare
|
@adammorr could you please re-approve please, I forced pushed to retrigger appveyor, which didn't respond to the first commit for some reason. |
adammorr
approved these changes
Nov 20, 2018
|
@slang25 it is done |
|
My eyes! 🙈 |
|
@martincostello |
|
Still have to see it before you change the option 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With credit to @martincostello for the gitattribute specifics. If we merge this and I do the same for #426, it should be much easier to review.