Fix ClassSetCharacter parsing #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ was removed from ClassSetReservedPunctuator See tc39/proposal-regexp-v-flag#60
JLHwung
force-pushed
the
fix-unicode-set-class-contents
branch
from
4e4ba86 to
af5ee57
Compare
JLHwung
commented
Sep 26, 2024
| @@ -914,76 +914,10 @@ | |||
| "raw": "[[a-z]&&[p-s]]" | |||
| }, | |||
| "[AB&&CD]": { | |||
There was a problem hiding this comment.
This is invalid in unicode sets mode. V8 12.6 also throws "Invalid set operation in character class".
JLHwung
commented
Sep 26, 2024
| "message": "Invalid set operation in character class at position 3\n [@@]\n ^", | ||
| "input": "[@@]" | ||
| }, | ||
| "[^^^]": { |
There was a problem hiding this comment.
/[^^]/v is actually valid due to the negation. To test the reserved double punctuator we have to construct a case where ^^ is seen in the middle.
|
Hi @JLHwung , thanks for your PR! From a coding side, this looks good to me. Waiting in case @nicolo-ribaudo has comments. |
nicolo-ribaudo
approved these changes
Oct 1, 2024
|
Thank you for the PR @JLHwung and thank you @nicolo-ribaudo for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we fixed two spec compliance issues about the regexp unicode sets mode.
We also aligned the production names in comments to the latest ES2025 draft, so it is easier to check the implementation.
Please review this PR by commits. The second and third one are the actual fixes.
/cc @nicolo-ribaudo