Use eslint-plugin-regexp #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_ was removed from ClassSetReservedPunctuator See tc39/proposal-regexp-v-flag#60
Avoid using annexB regexp syntax
\d is shorter than [0-9]
This rule recommends to simplify the following usage /^[dDsSwW]/ to /^[dsw]/i This regex is for matching the CharacterClassEscape // CharacterClassEscape :: one of d D s S w W If we simplify to the /i flag and suppose CharacterClassEscape now allows a new production `x` but not `X`, it is prone to errors that we accidentally allows `X` because of the `i` flag. For this reason I suggest to disable this rule.
JLHwung
commented
Sep 27, 2024
| @@ -762,7 +762,7 @@ | |||
| // PatternCharacter | |||
| return createCharacter(res); | |||
| } | |||
| else if (!isUnicodeMode && (res = matchReg(/^(?:]|})/))) { | |||
| else if (!isUnicodeMode && (res = matchReg(/^(?:\]|\})/))) { | |||
There was a problem hiding this comment.
Aside: Should we introduce an annexB: boolean option? When this option is false, it will reject any annexB productions. We can default it to true to avoid breaking changes, but users can opt-in to the modern stricter regex syntax.
There was a problem hiding this comment.
More than happy to accept a PR implementing this!
|
Great! Does |
Yes Line 16 in 47eaf14 |
|
Thanks for this PR @JLHwung ! I will make a release most likely tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce an ESLint plugin
eslint-plugin-regexpand enable most of its recommended rules. Then we fixed all lint errors for each different rules.This PR is based on #143 so that that PR is also linted against the new ESLint plugin. I will rebase once that PR gets merged.