Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL]Fix constraints/indexes detection bug #162

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Feb 17, 2020

  • When FK and UNIQUE are assigned to the same column
  • When PRIMARY KEY and UNIQUE are assigned to the same column

@k1LoW k1LoW added the bug Something isn't working label Feb 17, 2020
@k1LoW k1LoW self-assigned this Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #162 into master will decrease coverage by 1.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   68.81%   67.73%   -1.09%     
==========================================
  Files          13       13              
  Lines        2851     2851              
==========================================
- Hits         1962     1931      -31     
- Misses        692      729      +37     
+ Partials      197      191       -6
Impacted Files Coverage Δ
drivers/mysql/mysql.go 81.99% <100%> (ø) ⬆️
datasource/datasource.go 20.85% <0%> (-19.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91afe4b...0ccde33. Read the comment docs.

- When FK and UNIQUE are assigned to the same column
- When PRIMARY KEY and UNIQUE are assigned to the same column
@k1LoW k1LoW force-pushed the fix-detect-constraints-mysql branch from e021d46 to 0ccde33 Compare February 17, 2020 07:24
@k1LoW k1LoW merged commit 105d788 into master Feb 17, 2020
@k1LoW k1LoW deleted the fix-detect-constraints-mysql branch February 17, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant