Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSSQL comments trimmed to 30 chars #238

Merged
merged 3 commits into from
May 13, 2020
Merged

Fix MSSQL comments trimmed to 30 chars #238

merged 3 commits into from
May 13, 2020

Conversation

paulKabira
Copy link
Contributor

Ref: #232

paulKabira and others added 2 commits May 12, 2020 20:06
@paulKabira
Merge pull request #1 from k1LoW/master
43f4e81 
Sync with Master
Fix MSSQL comment error when greater than 30 chars
667e502 
Fix comments trimmed to 30 chars for mssql driver
@k1LoW
Copy link
Owner

k1LoW commented May 13, 2020

@paulKabira Thank you for your fix !!!

@k1LoW
Copy link
Owner

k1LoW commented May 13, 2020

@paulKabira Could you remove tbls.exe from pull request ?

@k1LoW k1LoW added the bug Something isn't working label May 13, 2020
@k1LoW k1LoW self-assigned this May 13, 2020
@paulKabira
Copy link
Contributor Author

Thanks for pointing it out, I have removed tbls.exe.

k1LoW
k1LoW approved these changes May 13, 2020
View reviewed changes
Copy link
Owner

@k1LoW k1LoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!!

@k1LoW k1LoW merged commit 7c4945d into k1LoW:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1LoW k1LoW k1LoW approved these changes

Assignees

@k1LoW k1LoW

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulKabira @k1LoW