Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSSQL comments trimmed to 30 chars #238

Merged
merged 3 commits into from
May 13, 2020
Merged

Fix MSSQL comments trimmed to 30 chars #238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43f4e81
Merge pull request #1 from k1LoW/master
paulKabira May 12, 2020
667e502
Fix MSSQL comment error when greater than 30 chars
May 12, 2020
6e6bd1f
Remove tbls.exe
May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions drivers/mssql/mssql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (m *Mssql) Analyze(s *schema.Schema) error {

// tables and comments
tableRows, err := m.db.Query(`
SELECT schema_name(schema_id) AS table_schema, o.name, o.object_id, o.type, cast(e.value as NVARCHAR) AS table_comment
SELECT schema_name(schema_id) AS table_schema, o.name, o.object_id, o.type, cast(e.value as NVARCHAR(MAX)) AS table_comment
FROM sys.objects AS o
LEFT JOIN sys.extended_properties AS e ON
e.major_id = o.object_id AND e.name = 'MS_Description' AND e.minor_id = 0
Expand Down Expand Up @@ -111,10 +111,10 @@ SELECT
c.is_nullable,
c.is_identity,
object_definition(c.default_object_id),
CAST(e.value AS VARCHAR) AS column_comment
CAST(e.value AS NVARCHAR(MAX)) AS column_comment
FROM sys.columns AS c
LEFT JOIN sys.types AS t ON c.system_type_id = t.system_type_id
LEFT JOIN sys.extended_properties e ON
LEFT JOIN sys.extended_properties AS e ON
e.major_id = c.object_id AND e.name = 'MS_Description' AND e.minor_id = c.column_id
WHERE c.object_id = $1
and t.name != 'sysname'
Expand Down