Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Enable Typescript check for Production build #1725

Open
lordrip opened this issue May 3, 2023 · 0 comments
Open

Enable Typescript check for Production build #1725

lordrip opened this issue May 3, 2023 · 0 comments
Labels
chore Tests, CI/CD, general maintenance good first issue Good for newcomers

Comments

@lordrip
Copy link
Collaborator

lordrip commented May 3, 2023 •
edited
Loading

Please describe the task that needs to be done

Context

Currently, Typescript is disabled on dev and prod builds, leading practically to no check at all. related read

The goal for this chore would be:

  1. Enable Typescript type check in DEV mode via fork-ts-checker.
  2. Enable Typescript type check in PROD mode.
  3. Fix any type-error that might be lurking around waiting for the next victim.
@lordrip lordrip added good first issue Good for newcomers chore Tests, CI/CD, general maintenance labels May 3, 2023
@lordrip lordrip mentioned this issue May 3, 2023
Merged
lordrip added a commit that referenced this issue May 3, 2023
@lordrip
chore: Enable Typescript for Production builds
ffac4cf 
Currently, we're using [ts-loader](https://github.com/TypeStrong/ts-loader)
to load and parse Typescript modules only, without doing
typechecks.

This commmit enables Typescript for Production builds
while keeping the existing config for Dev builds.

The latter it's likely to change in the future in favor of
[fork-ts-checker-webpack-plugin](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin)

relates: [1725](#1725)
@lordrip lordrip mentioned this issue May 5, 2023
Merged
kahboom pushed a commit that referenced this issue May 5, 2023
@lordrip
fix(stepsService): Pass step's UUID to the getStepNested method (#1746)
acff05b 
Currently, we're passing a whole step into the getStepNested method instead
of a string.

This is caused because of how the IVizStepNode interface it's defined, turning
the whole Step typing into any.

Relates to: #1725
Relates to: #1232
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
chore Tests, CI/CD, general maintenance good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lordrip