This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(stepsService): Avoid passing a whole step into the getStepNested method #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 72 72
Lines 2075 2075
Branches 470 470
=======================================
Hits 1388 1388
Misses 645 645
Partials 42 42
|
kahboom
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, we're passing a whole step into the getStepNested method instead of a string.
This is caused because of how the IVizStepNode interface it's defined, turning
the whole Step typing into any.
Relates to: #1725
Relates to: #1232