CurveSNARK1 for Go #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
reviewed
May 15, 2018
bls/mcl.go
Outdated
| @@ -9,6 +9,9 @@ import "C" | |||
| import "fmt" | |||
| import "unsafe" | |||
|
|
|||
| // CurveSNARK1 -- | |||
There was a problem hiding this comment.
Probably worth adding here “curve for SNARKs; corresponds to the curve primitives on the Ethereum VM”.
Shadowfiend
added a commit
to keep-network/keep-core
that referenced
this pull request
May 17, 2018
CurveSNARK1 exposed from mcl After merging keep-network/go-dfinity-crypto#1 we update revision constraint for go-dfinity-crypto to the newest one and switch the Init curve to CurveSNARK1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs keep-network/keep-core#31
This PR is the second step towards exposing CurveSNARK1 to our Go code.
The plan is as follows:
bn- done in CurveSNARK1 for Go bn#1go-dfinity-crypto<- we are here!I added
CurveSNARK1case to MCL test. You can run all tests with: