CurveSNARK1 exposed from mcl #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 15, 2018 23:48
Our previous approach with `rand.NewRand` was generating ids too big for the new curve and as a result we were losing information when marshalling/unmarshalling.
|
Question: do we want to just do the first commit as a PR (since it just bumps the dependency), and work on BLS-with-SNARK1 in a separate branch? |
I think the failing Docker image build (which I am working on right now) is the last outstanding thing here. My understanding is that if we have I still observe |
|
Hmmm, okay. Let's pick up the question about |
Shadowfiend
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #31
After merging keep-network/go-dfinity-crypto#1 we update
revisionconstraint forgo-dfinity-cryptoto the newest one.