Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): Add crowdin strings for Dutch #7498

Merged
merged 5 commits into from
Oct 27, 2022
Merged

chore(common): Add crowdin strings for Dutch #7498

merged 5 commits into from
Oct 27, 2022

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Oct 20, 2022 •
edited by sgschantz
Loading

This adds the crowdin strings for Nederlands (Dutch) - locale nl-NL

TODO for @sgschantz

  • Run XCode for iOS
  • Run XCode for macOS

User Testing

Load the PR build for each platform and set the UI / Locale to Dutch
There may be a handful of strings still in English, but most are in Dutch

  • TEST_ANDROID
  1. Load the PR build of Keyman for Android
  2. In the Keyman app, go to Settings --> Display Language --> Nederlands (Dutch)
  3. Return to the Keyman app
  4. Verify the UI is in Dutch (prompt, Settings strings, etc.).
  • TEST_IOS
  1. Load the PR build of Keyman for iPhone and iPad
  2. Set the device locale to Dutch
  3. Return to the Keyman app
  4. Verify the UI is in Dutch
  • TEST_LINUX
  1. Start Keyman configuration with: LANGUAGE=nl_NL km-config
  2. Verify Keyman UI is in Dutch
  • TEST_MACOS
  1. Load the PR build of Keyman for macOS
  2. Set the locale to Dutch
  3. Verify the Keyman UI is in Dutch
  • TEST_WINDOWS
  1. Load the PR build of Keyman for Windows
  2. Set the UI to Nederlands
  3. Verify the Keyman UI is in Dutch

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 20, 2022
@darcywong00 darcywong00 added this to the A16S13 milestone Oct 20, 2022
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 20, 2022 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_ANDROID (PASSED): Tested this PR with the attached build (Keyman 16.0.85-alpha-test-7498) in API 26 / Android 8.0 emulator and verified that the Keyman Config has been changed to Dutch UI. (notes)
  • ✅ TEST_IOS (PASSED): Tested this PR in iOS 16 / iPhone 14 Pro Max Simulator and verified that the Dutch UI is in Keyman App. (notes)
  • ✅ TEST_LINUX (PASSED): Tested this as per the instructions and verified that the Keyman UI is in Dutch. (notes)
  • ✅ TEST_MACOS (PASSED): Tested this in macMini M1 12.6 Monterey OS and verified that the Dutch UI is in Keyman dialog. (notes)
  • ✅ TEST_WINDOWS (PASSED): Retested this with the update PR build and verified that the Dutch UI is in the Keyman Configuration dialogue. (notes)

Test Artifacts

@darcywong00 darcywong00 marked this pull request as ready for review October 24, 2022 03:10
@darcywong00
Copy link
Contributor Author

Commit 5b59cca adds the newest mac string for privacy-alert-text

@bharanidharanj
Copy link

  • TEST_LINUX (PASSED): Tested this as per the instructions and verified that the Keyman UI is in Dutch.

@bharanidharanj
Copy link

  • TEST_ANDROID (PASSED): Tested this PR with the attached build (Keyman 16.0.85-alpha-test-7498) in API 26 / Android 8.0 emulator and verified that the Keyman Config has been changed to Dutch UI.

@bharanidharanj
Copy link

  • TEST_IOS (PASSED): Tested this PR in iOS 16 / iPhone 14 Pro Max Simulator and verified that the Dutch UI is in Keyman App.

  • TEST_MACOS (PASSED): Tested this in macMini M1 12.6 Monterey OS and verified that the Dutch UI is in Keyman dialog.

@bharanidharanj
Copy link

  • TEST_WINDOWS (FAILED): Tested this PR in Windows 10 (Native Machine) OS and noticed that there is no Nederlands UI / Dutch UI appear in the UI drop down list box.

@keymanapp-test-bot keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Oct 27, 2022
@github-actions github-actions bot added common/ and removed common/ labels Oct 27, 2022
@darcywong00
Copy link
Contributor Author

@bharanidharanj -
In Keyman Setup - "Nederlands" is an available option. But you're right about it not being an option in Keyman Configuration.
I found a language code the translator should have kept as en and fixed it. That should fix "English" from showing twice in the UI list.

@keymanapp-test-bot retest TEST_WINDOWS

@keymanapp-test-bot keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Oct 27, 2022
@bharanidharanj
Copy link

bharanidharanj commented Oct 27, 2022 •
edited
Loading

@bharanidharanj - In Keyman Setup - "Nederlands" is an available option. But you're right about it not being an option in Keyman Configuration. I found a language code the translator should have kept as en and fixed it. That should fix "English" from showing twice in the UI list.

@keymanapp-test-bot retest TEST_WINDOWS

@darcywong00 Oh Okay. FYI, I just added an issue about the English UI name appears twice in the list box. #7559

@bharanidharanj
Copy link

  • TEST_WINDOWS (PASSED): Retested this with the update PR build and verified that the Dutch UI is in the Keyman Configuration dialogue.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 27, 2022
@darcywong00 darcywong00 merged commit df0153f into master Oct 27, 2022
@darcywong00 darcywong00 deleted the chore/common/crowdin-nl branch October 27, 2022 13:25
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 16.0.90-alpha

@mcdurdin mcdurdin mentioned this pull request Oct 27, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton jahorton approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

@ermshiperete ermshiperete Awaiting requested review from ermshiperete ermshiperete is a code owner

@sgschantz sgschantz Awaiting requested review from sgschantz sgschantz is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL is a code owner

Assignees

@bharanidharanj bharanidharanj

Labels
android/app/ android/engine/ android/ chore common/ has-user-test ios/app/ ios/engine/ ios/ linux/config/ linux/ mac/ windows/config/ windows/
Projects
None yet
Milestone
A16S13
Development

Successfully merging this pull request may close these issues.
6 participants
@darcywong00 @bharanidharanj @keyman-server @mcdurdin @jahorton @sgschantz