-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pull-policy flag to service #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasgun: 1 warning.
In response to this:
Description
Added
--pull-policy
option which will set the ImagePullPolicy field in the Knative service. Valid options are: Never | Always | IfNotPresentChanges
- Added the flat to set image pull policy
Reference
Fixes #578
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 79.93% 79.27% -0.67%
==========================================
Files 171 171
Lines 9116 12906 +3790
==========================================
+ Hits 7287 10231 +2944
- Misses 1116 1955 +839
- Partials 713 720 +7
Continue to review full report at Codecov.
|
/retest |
2a550af
to
0317ff6
Compare
/retest |
/retest |
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added
--pull-policy
option which will set the ImagePullPolicy field in the Knative service. Valid options are: Never | Always | IfNotPresentChanges
Reference
Fixes #578