Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pull-policy flag to service #1644

Merged
merged 8 commits into from
Apr 13, 2022
Merged

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Apr 11, 2022

Description

Added --pull-policy option which will set the ImagePullPolicy field in the Knative service. Valid options are: Never | Always | IfNotPresent

Changes

  • Added the flat to set image pull policy

Reference

Fixes #578

Copy link

@knative-prow knative-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasgun: 1 warning.

In response to this:

Description

Added --pull-policy option which will set the ImagePullPolicy field in the Knative service. Valid options are: Never | Always | IfNotPresent

Changes

  • Added the flat to set image pull policy

Reference

Fixes #578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/serving/config_changes.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1644 (1e6fb97) into main (38b1034) will decrease coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   79.93%   79.27%   -0.67%     
==========================================
  Files         171      171              
  Lines        9116    12906    +3790     
==========================================
+ Hits         7287    10231    +2944     
- Misses       1116     1955     +839     
- Partials      713      720       +7     
Impacted Files Coverage Δ
pkg/serving/config_changes.go 96.61% <ø> (+5.30%) ⬆️
pkg/kn/flags/podspec.go 77.32% <100.00%> (-1.93%) ⬇️
pkg/kn/flags/podspec_helper.go 78.42% <100.00%> (+1.55%) ⬆️
pkg/kn/flags/channel_types.go 86.44% <0.00%> (-6.90%) ⬇️
pkg/kn/commands/source/list.go 55.73% <0.00%> (-5.97%) ⬇️
pkg/kn/commands/domain/update.go 60.86% <0.00%> (-5.80%) ⬇️
pkg/kn/commands/human_readable_flags.go 82.22% <0.00%> (-5.78%) ⬇️
pkg/kn/commands/trigger/delete.go 70.00% <0.00%> (-5.00%) ⬇️
pkg/kn/commands/version/version.go 74.32% <0.00%> (-4.99%) ⬇️
pkg/kn/commands/domain/list.go 66.66% <0.00%> (-4.77%) ⬇️
... and 163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0993e23...1e6fb97. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2022
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2022
@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 11, 2022

/retest

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2022
pkg/kn/flags/podspec.go Outdated Show resolved Hide resolved
@vyasgun vyasgun force-pushed the pr/pull-policy branch 2 times, most recently from 2a550af to 0317ff6 Compare April 11, 2022 20:02
@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 12, 2022

/retest

@vyasgun
Copy link
Contributor Author

vyasgun commented Apr 12, 2022

/retest

@dsimansk
Copy link
Contributor

Thanks!

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@knative-prow knative-prow bot merged commit bb7fd73 into knative:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a flag to set ImagePullPolicy
3 participants