-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update set-up-a-local-knative-environment-with-kind.md #4945
Conversation
Fix borked instructions to latest (Updated kind install, apiVersion string, kourier.yaml instructions)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xtaje The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @xtaje. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@csantanapr Since we have the quickstart plugin, do we still want to maintain this blog post? |
I found it to be useful in getting a kind instance working with locally loaded images. That could be helpful since it will be a common use case for a lot of people. |
@xtaje I would preferred folks to use Knative kn quickstart is there something we can add to the plugin that we can retire the blog? |
Re-reading the blog the “kn quickstart kind” does the same setup with kind and kourier |
If you replaced this blog with one on how to setup locally loaded images or local registries with kind or minikube, I think that would be good. I don't think there's an easy way to make that a kn quickstart command though. |
@xtaje can you elaborate what you mean by local images? This blog post doesn't mention or teach the user about the kind command to load images it just teach the user on how to install knative on kind the cluster. The kn quickstart does the same that this blog does Are you referring to the kind node image already preloaded you can use the flag in kn quickstart You are talking about loading images with kind command you can do that even with ko and kind.local Setting up a docker registry with locally with cover and use by kind cluster you can also do and this blog doesn't teach you how but we can add docs to kn quickstart. I just want to get better understand what this blog says that we can't get with kn quickstart kind even if we don't do it for minikube |
Kn quickstart can even work with an existing kind cluster that you setup with your specific config and just installs knative |
Disabling the tag to digest resolution is not obvious, and is necessary to make a locally loaded image work with a kn service. This is going to be a very common thing to do for people who are trying to learn knative, and I don't believe it's safe to assume that they'll all be familiar with kind already. It also doesn't seem appropriate to build the I've almost got a separate blog post ready that demonstrates how to do it using the cluster created by |
Great feedback Did you know that there is no need to disable tag resolution if you use the container image location server kind.local or dev.local? This was my thinking to document or blog that tell folks about doing a rocker build like “docker build -t kind.local/myapp .” then do a a “kind load docker-image kind.local/myapp” They deploy Knative service no need to disable tag resolution. |
I've put in a PR for a tutorial: #4948. I probably should add a section about kind.local. I think there's benefit to demonstrating the tag resolution, because the question people will immediately have is, "How do I try this without re-naming all my images?". Or they may have some kind of CI process where changing all the image names is a big hassle. |
I'm finding that this still gets stuck waiting for a Revision to become ready because:
|
Client v1.4 has support for pull policy |
Closing as no longer necessary. |
Fix borked instructions to latest (Updated kind install, apiVersion string, kourier.yaml instructions)
Fixes #4880
Proposed Changes