Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton downstream test #2233

Merged
merged 4 commits into from
Aug 25, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/knative-downstream.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

name: Downstream
name: Downstream Knative

on:
pull_request:
Expand Down
64 changes: 64 additions & 0 deletions .github/workflows/tekton-downstream.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# Copyright 2020 The Knative Authors.
mattmoor marked this conversation as resolved.
Show resolved Hide resolved
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: Downstream Tekton

on:
pull_request:
branches: [ 'main', 'master', 'release-*' ]

jobs:

downstream-tekton:
name: Unit Test

strategy:
fail-fast: false # Keep running if one leg fails.
matrix:
include:
- repo: pipeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only real change right? Is it bad to just add this to the original downstream tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other tests hardcode knative.dev import paths some unfortunate places

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which aren't easily conditioned away)

org: tektoncd

runs-on: ubuntu-latest

env:
GOPATH: ${{ github.workspace }}

steps:

- name: Set up Go 1.16.x
uses: actions/setup-go@v2
with:
go-version: 1.16.x

- name: Install Dependencies
run: |
go get github.com/google/go-licenses

- name: Checkout Upstream
uses: actions/checkout@v2
with:
path: ./src/knative.dev/${{ github.event.repository.name }}

- name: Checkout Downstream
uses: actions/checkout@v2
with:
repository: ${{ matrix.org }}/${{ matrix.repo }}
path: ./src/github.com/${{ matrix.org }}/${{ matrix.repo }}

- name: Test Downstream
uses: knative-sandbox/[email protected]
with:
upstream-module: knative.dev/${{ github.event.repository.name }}
downstream-module: github.com/${{ matrix.org }}/${{ matrix.repo }}