Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tekton downstream test #2233

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Add Tekton downstream test #2233

merged 4 commits into from
Aug 25, 2021

Conversation

mattmoor
Copy link
Member

/kind cleanup

Release Note

Docs

@knative-prow-robot knative-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 24, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 24, 2021
@mattmoor mattmoor changed the title Add Tekton downstream test [WIP] Add Tekton downstream test Aug 24, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2021
@codecov
Copy link

codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

Merging #2233 (ed539ca) into main (12d915e) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ed539ca differs from pull request most recent head ec0f1a5. Consider uploading reports for the commit ec0f1a5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
+ Coverage   63.89%   63.92%   +0.02%     
==========================================
  Files         220      220              
  Lines        9536     9543       +7     
==========================================
+ Hits         6093     6100       +7     
+ Misses       3169     3168       -1     
- Partials      274      275       +1
Impacted Files Coverage Δ
test/gcs/mock/mock.go 90.32% <0.00%> (-1.08%) ⬇️
configmap/parse.go 100.00% <0.00%> (ø)
version/version.go 87.50% <0.00%> (ø)
test/helpers/name.go 100.00% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d915e...ec0f1a5. Read the comment docs.

@mattmoor
Copy link
Member Author

/retest

MetricsExporter

@mattmoor
Copy link
Member Author

This needs the following to land (and be released): https://github.com/knative-sandbox/actions-downstream-test/pull/12

It also needs a small cleanup in Tekton: tektoncd/pipeline#4189

imjasonh
imjasonh reviewed Aug 24, 2021
View reviewed changes
.github/workflows/tekton-downstream.yaml Outdated Show resolved Hide resolved
.github/workflows/tekton-downstream.yaml Outdated Show resolved Hide resolved
@mattmoor
Copy link
Member Author

/retest

Opencensus flake 🙃

@mattmoor
Copy link
Member Author

Ok, I hopefully have a fix for the Tekton test bug staged here: tektoncd/pipeline#4192. If that gets merged, I'll kick this again, and if it's green we can get it reviewed/merged. 🤞

@mattmoor mattmoor changed the title [WIP] Add Tekton downstream test Add Tekton downstream test Aug 25, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2021
@mattmoor
Copy link
Member Author

Ok so pipeline passed. Let's land this and then I can explore adding others :)

@mattmoor
Copy link
Member Author

/assign @n3wscott

n3wscott
n3wscott reviewed Aug 25, 2021
View reviewed changes
.github/workflows/tekton-downstream.yaml
fail-fast: false # Keep running if one leg fails.
matrix:
include:
- repo: pipeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only real change right? Is it bad to just add this to the original downstream tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other tests hardcode knative.dev import paths some unfortunate places

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which aren't easily conditioned away)

n3wscott
n3wscott approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 46a3611 into knative:main Aug 25, 2021
@mattmoor mattmoor deleted the tekton-downstream branch August 25, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@n3wscott n3wscott n3wscott approved these changes

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmoor @knative-prow-robot @imjasonh @n3wscott