Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more information on UI for helm test API response #195

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Adding more information on UI for helm test API response #195

merged 1 commit into from
Feb 1, 2023

Conversation

harshit-mehtaa
Copy link
Contributor

Fixes Issue

#115
#178

Changes proposed

  • Migrate existing API (for helm test) to use object model

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

image

image

image

@undera
Copy link
Collaborator

undera commented Jan 19, 2023

here's the question: is it possible to tell if chart has tests or not, based on its properties? Then, we could expose that in a field like hasTests and hide the button if there are no tests

@toddtee
Copy link
Contributor

toddtee commented Jan 20, 2023

here's the question: is it possible to tell if chart has tests or not, based on its properties? Then, we could expose that in a field like hasTests and hide the button if there are no tests

Yep, this is a much better UX.

@harshit-mehtaa
Copy link
Contributor Author

I did not find any such API/command to get such details
I am checking with the helm team on slack if there is some way for it

@undera
Copy link
Collaborator

undera commented Jan 20, 2023

According to helm source code, tests are hooks of release.HookTest type. We have access to the list of hooks for release, thus can detect that.

@undera
Copy link
Collaborator

undera commented Jan 31, 2023

I have added the required field with #326a555

@undera
Copy link
Collaborator

undera commented Jan 31, 2023

@hdm23061993 Do you plan to work more on this one?

@harshit-mehtaa
Copy link
Contributor Author

Thanks @undera 👍
I will use that and implement the recommendations

@undera
Copy link
Collaborator

undera commented Feb 1, 2023

@hdm23061993 I am planning to merge 1.0 PR today. Do you want to merge this PR before 1.0 released?

@harshit-mehtaa
Copy link
Contributor Author

it will take me a day or two to complete this one
Do you want to take it ahead and handle the recommendation?
This way we can have the complete feature in v1.0

@undera
Copy link
Collaborator

undera commented Feb 1, 2023

Ok, I'll merge this one and will take it from there. Thanks!

@undera undera merged commit 3876c4a into komodorio:features-1.0 Feb 1, 2023
@harshit-mehtaa
Copy link
Contributor Author

Thank you @undera 🥇

@harshit-mehtaa harshit-mehtaa deleted the features-1.0 branch February 1, 2023 10:34
undera added a commit that referenced this pull request Feb 1, 2023
@undera
Hide test button when no tests
6cff04d 
Fixes #115
Improves #195
@undera
Copy link
Collaborator

undera commented Feb 1, 2023

FYI you can see the commit a made to complete it

@harshit-mehtaa
Copy link
Contributor Author

Reviewed
Thanks for completing the feature before release v1.0 👍

undera added a commit that referenced this pull request Feb 1, 2023
@undera @OmAximani0
@harshit-mehtaa @toddtee @arvindsundararajan98
[WIP] Major release 1.0 (#147)
e13aa2f 
* Object model with self-sufficient binary (#131)

* Code cosmetics

* Experimenting with object model and direct HELM usage

* Experiment with object model

* replacing the kubectl

* Progressing

* Save the progress

* Able to start with migration in mind

* Migrated two pieces

* List releases via Helm

* Forgotten field

* Cristallized the problem of ctx switcher

* Reworked to multi-context

* Rollback is also new style

* More migration

* Refactoring

* Describe via code

* Bye-bye kubectl binary

* Eliminate more old code

* Refactor a bit

* Merges

* No binaries in dockerfile

* Commit

* Progress with getting the data

* Learned the thing about get

* One field less

* Sstart with repos

* Repo add

* repo remove

* Repos! Icons!

* Simplified access to data

* Ver listing works

* Ver check works

* Caching and values

* fixup

* Done with repos

* Working on install

* Install work-ish

* Fix UI failing on install

* Upgrade flow works

* Fix image building

* Remove outdated test file

* Move files around

* REfactorings

* Cosmetics

* Test for cache control (#151)

* Files import formatted

* Added go-test tools

* Added test for no-cache header

* added changes

* test for cache behaviour of app

* test for static route (#153)

* Tests: route configuration & context setter (#154)

* Test for route configuration

* Test for context setter middleware

* implemented changes

* Restore coverage profile

Fixes #156

* Cosmetics

* Test for `NewRouter` function (#157)

* Test for `configureScanners` (#158)

* Test for `configureKubectls` (#163)

* Test for repository loading (#169)

- Created `repos_test.go`
- Test: `Load()` of Repositories

* Build all PRs

* Fixes failing test (#171)

* Fixes failing test
- Fixes failing test of repo loading

* handles error for

* Did some changes

* Test for listing of repos (#173)

- and did some code formatting

Signed-off-by: OmAxiani0 <[email protected]>

Signed-off-by: OmAxiani0 <[email protected]>

* Test for adding repo (#175)

- Modified the `repositories.yml` file

Signed-off-by: OmAxiani0 <[email protected]>

Signed-off-by: OmAxiani0 <[email protected]>

* Test for deleting the repository (#176)

* Test for deleting the repository
- Also added cleanup function for `TestAdd`

* Fixes failing test

* Add auto labeler for PR's (#174)

* Add auto labeler for PR's

* Add all file under .github/workflow to 'ci' label

Co-authored-by: Harshit Mehta <[email protected]>

* Test for getting repository (#177)

* Add github workflow for auto PR labeling (#181)

Co-authored-by: Harshit Mehta <[email protected]>

* Stub compilation

* Fixes around installing

* More complex test

* Using object model to execute helm test (#191)

* Expand test

* More test

* Coverage

* Add mutex for operations

* Rectore cluster detection code

* Change receiver to pointer

* Support multiple namespaces

* Cosmetics

* Update repos periodically

* fix tests

* Fix error display

* Allow reconfiguring chart without repo

* mute  linter

* Cosmetics

* Failing approach to parse manifests

Relates to #30

* Report the error properly

* ✅ Add test for dashboard/objects/data.go NewDataLayer (#199)

* Fix problem of wrong namespace

* Added unit tests for releases (#204)

* Rework API routes (#197)

* Bootstrap OpenAPI doc

* Renaming some routes

* Listing namespaces

* k8s part of things

* Repositories section

* Document scanners API

* One more API call

* Progress

* Reworked install flow

* History endpoint

* Textual info section

* Resources endpoint

* Rollback endpoint

* Rollback endpoint

* Unit tests

* Cleanup

* Forgotten tags

* Fix tests

* TODOs

* Rework manifest scanning

* add hasTests flag

* Adding more information on UI for helm test API response (#195)

* Hide test button when no tests

Fixes #115
Improves #195

---------

Signed-off-by: OmAxiani0 <[email protected]>
Co-authored-by: Om Aximani <[email protected]>
Co-authored-by: Harshit Mehta <[email protected]>
Co-authored-by: Harshit Mehta <[email protected]>
Co-authored-by: Todd Turner <[email protected]>
Co-authored-by: arvindsundararajan98 <[email protected]>
@nurayko nurayko mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-mehtaa @undera @toddtee