Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master gateway average ping conversion #337

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

BartArys
Copy link
Contributor

The average ping is erroneously converting the average millisecond ping to microseconds, this PR fixes that.

@BartArys BartArys requested a review from HopeBaron June 30, 2021 13:19
@HopeBaron
Copy link
Member

Although we are using milliseconds everywhere, shouldn't we change that to microseconds as well?

@BartArys
Copy link
Contributor Author

Although we are using milliseconds everywhere, shouldn't we change that to microseconds as well?

I doubt anyone will ever deal with sub ms latency. For rounding I thought it'd be better to store the average as a more precise unit.

@HopeBaron HopeBaron merged commit b0c1f34 into 0.7.x Jul 3, 2021
HopeBaron added a commit that referenced this pull request Jul 8, 2021
* Add a cache aware rest entity supplier (#338)

* add a cahe aware rest supplier/strategy

* abstract the new flow creation for storeAndEmit

* apply suggestions

* Reduce the number of iterations

rename storeAndEmit to storeOnEach

* update changelog

* Fix master gateway average ping conversion (#337)

* Change field visibility and single-expression return syntax (#335)

* changed the visibility for the name, descript.. and type field, changed the toRequest functions to single expression-styled returns

* remade .name and .description to public upon request, kept .type protected

* remade .type into read only (val)

* Implement select menus (#339)

* Add select menu json representation

* Add select menu builders

* add serialization tests for select menu interactions

* Add core implementation of select menus

* Update ButtonComponent docs

* Make SelectMenu min/max values a range

* Fix getGuildBanOrNull recursion (#341)

Fixes the self call in getGuildBanOrNull by delegating the call to the supplier instead

* Make UpdateMessageInteractionResponseCreateBuilder fields nullable (#340)

Makes the fields in the builder and request nullable where appropriate for updating a message

* improve readme

* api dump

* add breaking changes to changelog

* mention the type visibility change

[ci skip]

Co-authored-by: Bart Arys <[email protected]>
Co-authored-by: Noak Palander <[email protected]>
@HopeBaron HopeBaron deleted the fixes/master-gateway-average-ping-unit branch October 7, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants