Fix getGuildBanOrNull recursion #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the self call in getGuildBanOrNull by delegating the call to the supplier instead
HopeBaron
added a commit
that referenced
this pull request
Jul 8, 2021
* Add a cache aware rest entity supplier (#338) * add a cahe aware rest supplier/strategy * abstract the new flow creation for storeAndEmit * apply suggestions * Reduce the number of iterations rename storeAndEmit to storeOnEach * update changelog * Fix master gateway average ping conversion (#337) * Change field visibility and single-expression return syntax (#335) * changed the visibility for the name, descript.. and type field, changed the toRequest functions to single expression-styled returns * remade .name and .description to public upon request, kept .type protected * remade .type into read only (val) * Implement select menus (#339) * Add select menu json representation * Add select menu builders * add serialization tests for select menu interactions * Add core implementation of select menus * Update ButtonComponent docs * Make SelectMenu min/max values a range * Fix getGuildBanOrNull recursion (#341) Fixes the self call in getGuildBanOrNull by delegating the call to the supplier instead * Make UpdateMessageInteractionResponseCreateBuilder fields nullable (#340) Makes the fields in the builder and request nullable where appropriate for updating a message * improve readme * api dump * add breaking changes to changelog * mention the type visibility change [ci skip] Co-authored-by: Bart Arys <[email protected]> Co-authored-by: Noak Palander <[email protected]>
HopeBaron
pushed a commit
that referenced
this pull request
Jul 18, 2021
Fixes the self call in getGuildBanOrNull by delegating the call to the supplier instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the self call in getGuildBanOrNull by delegating the call to the supplier instead