Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bill of materials #388

Merged
merged 2 commits into from
Oct 3, 2021
Merged

Add bill of materials #388

merged 2 commits into from
Oct 3, 2021

Conversation

NyCodeGHG
Copy link
Contributor

@NyCodeGHG NyCodeGHG commented Sep 13, 2021

  • Extract publishing into its own gradle script plugin
  • Add bill of materials

This allows aligning kord dependency versions via Maven BOMS

dependencies {
constraints {
rootProject.subprojects.forEach { subproject ->
if (subproject.plugins.hasPlugin("maven-publish") && subproject.name != name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this block of code for

Copy link
Contributor Author

@NyCodeGHG NyCodeGHG Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds every kord module which applies the maven-publish plugin and is not the bom module as a constraint dependency.
it's also possible to add every module by hand

@HopeBaron HopeBaron self-requested a review September 21, 2021 11:45
@HopeBaron HopeBaron merged commit 636dc76 into kordlib:0.8.x Oct 3, 2021
@NyCodeGHG NyCodeGHG deleted the feature/bom branch October 3, 2021 10:25
@NyCodeGHG NyCodeGHG mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants