Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bom #440

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix bom #440

merged 1 commit into from
Nov 10, 2021

Conversation

NyCodeGHG
Copy link
Contributor

When I submitted the bom in #388 i used the wrong function and the bom is broken and includes all dependencies instead of just setting the version.

@HopeBaron
Copy link
Member

What's the difference between the two function calls, shouldn't these be the same?

@NyCodeGHG
Copy link
Contributor Author

That's what I thought when I submitted the first PR, but there is no api(String, String, String) in the constraints scope, that's the regular api function from the dependencies scope.
In the pom the dependencies are regular dependencies: https://repo1.maven.org/maven2/dev/kord/kord-bom/0.8.0-M7/kord-bom-0.8.0-M7.pom
But it should look like this: https://s01.oss.sonatype.org/content/repositories/snapshots/dev/nycode/github/bom/1.0.0-SNAPSHOT/bom-1.0.0-20211109.142957-14.pom

@HopeBaron
Copy link
Member

what about the removal of allowDependencies

@NyCodeGHG
Copy link
Contributor Author

NyCodeGHG commented Nov 9, 2021

Thats Gradle's way to prevent you from doing the mistake I did. But I did the mistake anyway. It's only needed when you want to include dependencies in the bom which are not constraint dependencies, when i understood correctly.

@HopeBaron HopeBaron merged commit 03a8dad into kordlib:0.8.x Nov 10, 2021
@NyCodeGHG NyCodeGHG deleted the fix/bom branch November 10, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants