Member Avatars & Avatar->Icon refactor #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HopeBaron
requested changes
Sep 30, 2021
There was a problem hiding this comment.
The overall design is pretty good. Im against making retrieving something related to the user from the avatar, when we can get the default avatar from the user itself with a property or a function as a defaultAvatar. Icons shall represent an image and shall not depend on external data of another entity.
Merged
BartArys
reviewed
Oct 1, 2021
BartArys
approved these changes
Oct 1, 2021
HopeBaron
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.