Implement Role Icons #402
Merged
Implement Role Icons #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test whether Kord's HttpClient works when retrieving these images? I remember there being an issue with Discord's CDN failing any request that had unknown header values, and Kord by default puts bot auth in every request. |
|
This was working in the old code, so I assumed it would. |
Fair point hah. I believe we just pushed it assuming it was a bug on Discord's end that would eventually get fixed. It's not really relevant to the PR then I suppose. |
# Conflicts: # core/src/main/kotlin/entity/Icon.kt
|
I resolved the merge conflict, this would be ready for review now too |
HopeBaron
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #401 - Uses DiscordCDN