-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable binary compatibility validation for KLibs #929
Conversation
I looked at this yesterday (before I sent you the news ^-^) however, there is an issue regarding #855, because K/N can only produce API dumps for targets it can compile for, this isn't a big deal for the check task, as we run on all hosts anyways, however now every PR needs to produce a dump for Linux, Windows and MAC, one way to fix this, would be to add a GitHub bot (via GitHub Actions or TeamCity) that will do that for you, if you comment something like |
i haven't experimented with native, but won't it just work for common code? |
No as it dumps the platform API not the common api |
running this on the
so we only need an apple machine if we would want to add apple only api |
When I did it it failed |
because the linux targets are disabled, there is no target left for |
Neither of which we can do, but that does indeed explain it |
it's at least a workaround so we don't have to build a bot for this. at some point the issue with linux targets may be fixed (?) or we will add js/windows targets to voice. then the dump can be inferred from there. |
The issue is with curl on windows, which will most definitely never get fixed |
The workaround for :core:live-tests is no longer needed.
See https://github.com/Kotlin/binary-compatibility-validator/blob/0.15.0-Beta.1/README.md#experimental-klib-abi-validation-support