-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command cargoLogin to login in all cargo registries #153
Conversation
kraken-build/src/kraken/std/cargo/tasks/cargo_sync_config_task.py
Outdated
Show resolved
Hide resolved
kraken-build/src/kraken/std/cargo/tasks/cargo_sync_config_task.py
Outdated
Show resolved
Hide resolved
Notes after a call: we should make sure this MR
|
Regarding the first two points, this MR does not touch For the last point, this is what #140 did, by adding |
Co-authored-by: Nicolas Trinquier <[email protected]>
I've only tested this marginally -- we really need some end-to-end tests that include a sparse and private registry. @Colin1860 recently added a test with https://github.com/d-e-s-o/cargo-http-registry but it's (1) not sparse and (2) accepts and credentials. I'm gonna go ahead with merging this anyway to unblock us integrating it into our internal extension module. |
It seems to work locally. Hopefully, it will also work in the CI.