Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert setting credentials providers by default in .cargo/config.toml with the :cargoSyncConfig task #213

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

NiklasRosenstein
Copy link
Contributor

@NiklasRosenstein NiklasRosenstein commented Mar 6, 2024

Reverts the changes in #153 that set the [registry].global-credential-providers in .cargo/config.toml as the default, and instead adds a property that would still allow setting it.

The issue is that in our CI it seems that libsecret is not currently available

error: failed to get `xyz` as a dependency of package `abc v0.0.0 (/builds/abc/abc-rs/comments)`
Caused by:
  credential provider `cargo:libsecret` failed action `get`
Caused by:
  failed to load libsecret: try installing the `libsecret` or `libsecret-1-0` package with the system package manager
Caused by:
  libsecret-1.so: cannot open shared object file: No such file or directory

I also am not sure if we should set this in a project's .cargo/config.toml; these settings might be more appropriate in the user's global configuration ($CARGO_HOME/config.toml).

@NiklasRosenstein NiklasRosenstein merged commit 22d0c4f into develop Mar 6, 2024
16 checks passed
@NiklasRosenstein NiklasRosenstein deleted the nr/revert-setting-credentials-providers branch March 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant