Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
this outputs an mjs file instead of a js file to node/module.mjs
@magic/core is using node 14.2.0 and mjs files without compilation, and, contrary to most build tools, nodejs is not capable to detect modules automagically when importing.
alternatively to this commit we could also set
"type": "module",
in package.json, but i would expect that to break some commonjs applications on older node versions.please note: i do not have a commonjs application ready to test this in!