Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid npm package (CommonJS and ESM) #20

Merged
merged 1 commit into from
May 25, 2020
Merged

Hybrid npm package (CommonJS and ESM) #20

merged 1 commit into from
May 25, 2020

Conversation

frenzzy
Copy link
Member

@frenzzy frenzzy commented May 25, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Read more: https://2ality.com/2019/10/hybrid-npm-packages.html

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          127       127           
  Branches        35        35           
=========================================
  Hits           127       127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c6b14...255db60. Read the comment docs.

@frenzzy frenzzy mentioned this pull request May 25, 2020
8 tasks
@frenzzy frenzzy merged commit 80acb7e into master May 25, 2020
@frenzzy frenzzy deleted the cjs-and-esm branch May 25, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants