Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated code after moving to Go 1.19 #386

Closed
ckadner opened this issue May 31, 2023 · 0 comments · Fixed by #422
Closed

Update deprecated code after moving to Go 1.19 #386

ckadner opened this issue May 31, 2023 · 0 comments · Fixed by #422
Assignees
Labels
enhancement New feature or request

Comments

@ckadner
Copy link
Member

ckadner commented May 31, 2023

controllers/servingruntime_validator.go:142:43: SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
func checkName(name string, internalNames sets.String, logStr string) error {
                                          ^
controllers/modelmesh/model_type_labels.go:26:11: SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
        mtLabels sets.String, pvLabels sets.String, rtLabel string) {
                 ^
controllers/modelmesh/model_type_labels.go:29:16: SA1019: sets.String is deprecated: use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string]() (staticcheck)
        mtSet := make(sets.String, 2*len(rt.SupportedModelFormats))
                      ^

For the time being, the following deprecation warnings/errors have been supressed:

   # Exclude some deprecation errors
    - linters:
        - staticcheck
      text: "SA1019:"

Originally posted by @ckadner in #379 (comment)

@rafvasq rafvasq added the enhancement New feature or request label Jun 1, 2023
@rafvasq rafvasq self-assigned this Aug 30, 2023
ckadner pushed a commit that referenced this issue Sep 13, 2023
Address deprecation warnings after updating to Go 1.19 (#379)
by updating deprecated code to use generic Set instead.

Resolves #386

---------

Signed-off-by: Rafael Vasquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants