release: Update KServe/dependencies #379

rafvasq · 2023-05-24T18:25:35Z

Motivation

Update KServe and dependencies in preparation for v0.11.0 release

Modifications

Update go.mod dependencies
Update CRDs under config/crd/bases
Remove outdated module replacements
Update Dockerfile.develop:
- Use Go 1.19
- Fix broken controller-gen install
- Add safe.directory work-around for the git dubious ownership error during the GHA lint workflow
Temporarily disable lint deprecation check "SA1019"
Update Copyright header formatting in *.go sources to not be mistaken as package documentation
Update mock client GETtion func signature in grpc_resolver_test.go

Result

Testing KServe RC in preparation for release

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner · 2023-05-24T18:50:33Z

@rafvasq -- I marked this as a draft until the go.mod changes are sorted out. I don't think we want/need to upgrade major package versions

ckadner

Thanks @rafvasq -- I know your are still working on this, so just a few points for now

config/crd/bases/serving.kserve.io_inferenceservices.yaml

go.mod

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner

Hi @rafvasq unless the KServe changes absolutely require it, I suggest we stick with go 1.18 for this release. Otherwise, there are too many subsequent changes we would have to make.

Dockerfile.develop

.pre-commit-config.yaml

scripts/deploy/iks/test-fvt.sh

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner · 2023-05-27T00:30:10Z

The build still failed locally even if I bring some of these dependencies back a version. The only way I was able to pass build/lint locally so far as been to upgrade to go 1.19 and golangci-lint to 1.52.2.

Right, I see now. KServe updated to Go 1.20 last week. So we are on the hook to follow suit. Sadly it's extremely late in the release cycle for such a change.

I can try to help with more changes required to accommodate that upgrade.

rafvasq · 2023-05-27T00:45:54Z

The build still failed locally even if I bring some of these dependencies back a version. The only way I was able to pass build/lint locally so far as been to upgrade to go 1.19 and golangci-lint to 1.52.2.

Right, I see now. KServe updated to Go 1.20 last week. So we are on the hook to follow suit. Sadly it's extremely late in the release cycle for such a change.

I can try to help with more changes required to accommodate that upgrade.

As discussed, we'll go for 1.19 after all because the go-toolset image we use is at 1.19

ckadner · 2023-05-27T01:08:06Z

Sounds good. I will try to make some more changes and push to your fork

- Remove outdated module replacements - Update Dockerfile.develop - Fix broken controller-gen install - Temporarily disable lint deprecation check "SA1019" - Update Copyright header formatting to not be mistaken as package documentation - Update mock client GET func signature in grpc_resolver_test.go Signed-off-by: Christian Kadner <[email protected]>

Outdated

Signed-off-by: Christian Kadner <[email protected]>

.github/workflows/build.yml

.github/workflows/lint.yml

Signed-off-by: Christian Kadner <[email protected]>

ckadner

@njhill -- I made a few more changes to pass all the pull request checks. Please add your /lgtm /approve when you get a change

ckadner

Adding a bit more context for some of the changes

.golangci.yaml

pkg/mmesh/grpc_resolver_test.go

Dockerfile.develop

Signed-off-by: Christian Kadner <[email protected]>

njhill

This looks great, thanks @ckadner.

Out of interest do you know if there were many additional issues going to go 20? Not suggesting we should do that for the release but would be a nice follow-on to align with core kserve.

kserve-oss-bot · 2023-05-31T22:03:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhill, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

njhill · 2023-05-31T22:03:36Z

/lgtm

ckadner · 2023-05-31T23:02:06Z

Out of interest do you know if there were many additional issues going to go 20? Not suggesting we should do that for the release but would be a nice follow-on to align with core kserve.

We went with Go 1.19 (not Go 1.20) just because the go-toolset image we use is at 1.19

Once there is a UBI image for 1.20 we can do another upgrade.

Update KServe and dependencies in preparation for v0.11.0 release: - Update go.mod - Update CRDs under config/crd/bases - Remove outdated module replacements - Update Dockerfile.develop: - Use Go 1.19 - Fix broken controller-gen install - Add safe.directory work-around for the git 'dubious ownership' error during the GHA `lint` workflow - Temporarily disable lint deprecation check "SA1019" - Update Copyright header formatting in *.go sources to not be mistaken as package documentation - Update mock client GET function signature in grpc_resolver_test.go Signed-off-by: Rafael Vasquez <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]> Signed-off-by: Luis Delossantos <[email protected]>

Address deprecation warnings after updating to Go 1.19 (#379) by updating deprecated code to use generic Set instead. Resolves #386 --------- Signed-off-by: Rafael Vasquez <[email protected]>

release: Prep/update KServe dependencies

b5c83b0

Signed-off-by: Rafael Vasquez <[email protected]>

rafvasq added this to the v0.11.0 milestone May 24, 2023

rafvasq requested review from ckadner and njhill May 24, 2023 18:25

Lints

b3a0bcc

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner marked this pull request as draft May 24, 2023 18:44

kserve-oss-bot added the do-not-merge/work-in-progress label May 24, 2023

ckadner self-assigned this May 24, 2023

ckadner requested changes May 24, 2023

View reviewed changes

config/crd/bases/serving.kserve.io_inferenceservices.yaml Show resolved Hide resolved

go.mod Show resolved Hide resolved

rafvasq added 2 commits May 24, 2023 14:58

Revert dependencies except kserve

e965702

Signed-off-by: Rafael Vasquez <[email protected]>

Bumps to go 1.19

994d642

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner previously requested changes May 26, 2023

View reviewed changes

Dockerfile.develop Show resolved Hide resolved

.pre-commit-config.yaml Outdated Show resolved Hide resolved

scripts/deploy/iks/test-fvt.sh Outdated Show resolved Hide resolved

Revert to 1.18

36c7cde

Signed-off-by: Rafael Vasquez <[email protected]>

ckadner added 2 commits May 30, 2023 11:48

Merge branch 'main' into prep-release

0798aad

ckadner self-requested a review May 30, 2023 22:36

Fix pre-commit linter failure after git dubious ownership error

9148c91

Signed-off-by: Christian Kadner <[email protected]>

ckadner reviewed May 30, 2023

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

ckadner reviewed May 30, 2023

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

ckadner added 6 commits May 30, 2023 15:58

error: could not lock config file /etc/gitconfig: Permission denied

c54c2ba

Signed-off-by: Christian Kadner <[email protected]>

Work around lint error dubious ownership of directory /workspace

369053f

Signed-off-by: Christian Kadner <[email protected]>

try non-global safe directory setting

be798ef

Signed-off-by: Christian Kadner <[email protected]>

lint: git add global safe directory /workspace

3546322

Signed-off-by: Christian Kadner <[email protected]>

Add global safe directory /workspace to Dockerfile.develop

d0378c6

Signed-off-by: Christian Kadner <[email protected]>

Update FVT go version to 1.19

4910b87

Signed-off-by: Christian Kadner <[email protected]>

Update fvt test script go version to 1.19

b8f5cd0

Signed-off-by: Christian Kadner <[email protected]>

ckadner marked this pull request as ready for review May 31, 2023 02:03

kserve-oss-bot removed the do-not-merge/work-in-progress label May 31, 2023

ckadner previously approved these changes May 31, 2023

View reviewed changes

ckadner assigned njhill and unassigned ckadner May 31, 2023

ckadner reviewed May 31, 2023

View reviewed changes

.golangci.yaml Show resolved Hide resolved

pkg/mmesh/grpc_resolver_test.go Show resolved Hide resolved

Dockerfile.develop Show resolved Hide resolved

Dockerfile.develop Show resolved Hide resolved

Update controller-gen version to last aligned with Go 1.19

d787f9b

Signed-off-by: Christian Kadner <[email protected]>

ckadner dismissed their stale review via d787f9b May 31, 2023 18:14

kserve deleted a comment from kserve-oss-bot May 31, 2023

Merge branch 'main' into prep-release

df3a55f

kserve deleted a comment from kserve-oss-bot May 31, 2023

njhill approved these changes May 31, 2023

View reviewed changes

kserve-oss-bot added the approved label May 31, 2023

kserve-oss-bot added the lgtm label May 31, 2023

ckadner mentioned this pull request May 31, 2023

Update deprecated code after moving to Go 1.19 #386

Closed

ckadner merged commit 4808804 into kserve:main May 31, 2023

ckadner mentioned this pull request Jun 1, 2023

Error "invalid field type" when running 'make generate' #387

Open

rafvasq mentioned this pull request Aug 30, 2023

chore: use generic Set instead of deprecated sets.String #422

Merged

ckadner mentioned this pull request Nov 23, 2023

Update Go to supported version (1.20) #452

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: Update KServe/dependencies #379

release: Update KServe/dependencies #379

rafvasq commented May 24, 2023 •

edited by ckadner

Loading

ckadner commented May 24, 2023

ckadner left a comment

ckadner left a comment

ckadner commented May 27, 2023 •

edited

Loading

rafvasq commented May 27, 2023

ckadner commented May 27, 2023

ckadner left a comment •

edited

Loading

ckadner left a comment

njhill left a comment

kserve-oss-bot commented May 31, 2023

njhill commented May 31, 2023

ckadner commented May 31, 2023

release: Update KServe/dependencies #379

release: Update KServe/dependencies #379

Conversation

rafvasq commented May 24, 2023 • edited by ckadner Loading

Motivation

Modifications

Result

ckadner commented May 24, 2023

ckadner left a comment

Choose a reason for hiding this comment

ckadner left a comment

Choose a reason for hiding this comment

ckadner commented May 27, 2023 • edited Loading

rafvasq commented May 27, 2023

ckadner commented May 27, 2023

ckadner left a comment • edited Loading

Choose a reason for hiding this comment

ckadner left a comment

Choose a reason for hiding this comment

njhill left a comment

Choose a reason for hiding this comment

kserve-oss-bot commented May 31, 2023

njhill commented May 31, 2023

ckadner commented May 31, 2023

rafvasq commented May 24, 2023 •

edited by ckadner

Loading

ckadner commented May 27, 2023 •

edited

Loading

ckadner left a comment •

edited

Loading