fail build on missing application name #438
Conversation
|
Hi @moficodes. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Co-authored-by: Tommy Li <[email protected]>
|
/lgtm |
|
/cc @animeshsingh |
|
/approve |
| @@ -845,7 +845,7 @@ func (c *KfConfig) SetApplicationParameter(appName string, paramName string, val | |||
| "profiles": KfAppsStackName, | |||
| "dex": "dex", | |||
| // Spartakus is its own application because we want kfctl to be able to remove it. | |||
| "spartakus": "spartakus", | |||
There was a problem hiding this comment.
minor: try to go fmt the file. seems dex and profiles are not justified.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan, moficodes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#446) * fail build on missing application name * add application index on missing application error * update index syntax
fixes #437
fixes formatting of struct