Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

fail build on missing application name #438

Merged
merged 3 commits into from
Nov 13, 2020
Merged

fail build on missing application name #438

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd94087
fail build on missing application name
moficodes Nov 10, 2020
62b0361
add application index on missing application error
moficodes Nov 10, 2020
9194d03
update index syntax
moficodes Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/kfconfig/loaders/v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ func (v V1) LoadKfConfig(def interface{}) (*kfconfig.KfConfig, error) {
config.Annotations = kfdef.Annotations
config.ClusterName = kfdef.ClusterName
config.Spec.Version = kfdef.Spec.Version
for _, app := range kfdef.Spec.Applications {
for i, app := range kfdef.Spec.Applications {
if app.Name == "" {
return nil, &kfapis.KfError{
Code: int(kfapis.INVALID_ARGUMENT),
Message: fmt.Sprintf("must have name for application. missing application name on application %d in kfdef", i),
moficodes marked this conversation as resolved.
Show resolved Hide resolved
}
}
application := kfconfig.Application{
Name: app.Name,
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/kfconfig/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ func (c *KfConfig) SetApplicationParameter(appName string, paramName string, val
"profiles": KfAppsStackName,
"dex": "dex",
// Spartakus is its own application because we want kfctl to be able to remove it.
"spartakus": "spartakus",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: try to go fmt the file. seems dex and profiles are not justified.

"spartakus": "spartakus",
// AWS Specific
"aws-alb-ingress-controller": KfAppsStackName,
"istio-ingress": "istio-ingress",
Expand Down