Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

fix(*) rm work service in controller_test.go #235

Merged
merged 9 commits into from
Dec 16, 2019
Merged

fix(*) rm work service in controller_test.go #235

merged 9 commits into from
Dec 16, 2019

Conversation

leileiwan
Copy link
Contributor

No description provided.

@leileiwan
fix(job_test) test case should not include worker service
22ea5ea
@leileiwan
Merge pull request #1 from kubeflow/master
4594b9f 
Generate Kubeflow PyTorchJob SDK (kubeflow#227)
@leileiwan
Merge pull request #2 from kubeflow/master
0a0401d 
fix(job_test) test case should not include worker service (kubeflow#231)
@leileiwan
feat(deletePodsAndServices):only delete master service
b9ac1c4
@leileiwan
docs(deletePodsAndServices): add comment for function deletePodsAndSe…
2c1dd63 
…rvices
@leileiwan
docs(deletePodsAndServices): modify the comment for function deletePo…
3303171 
…dsAndServices
@leileiwan
fix(*) rm work service in controller_test.go
dfc5482
@leileiwan
Merge branch 'master' of https://github.com/leileiwan/pytorch-operator
9827e8c
@leileiwan
Merge pull request #4 from kubeflow/master
5a4679b 
feat(deletePodsAndServices):only delete master service (kubeflow#233)
@k8s-ci-robot
Copy link

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leileiwan
Copy link
Contributor Author

for issue #228

@coveralls
Copy link

coveralls commented Dec 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 22.97% when pulling c0af20f on leileiwan:master into edfcb53 on kubeflow:master.

gaocegege
gaocegege reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 16, 2019
@johnugeorge
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 26f9d0c into kubeflow:master Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaocegege gaocegege gaocegege left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leileiwan @k8s-ci-robot @coveralls @johnugeorge @gaocegege