Update getting-started-multipass.md #1469
Conversation
Updating instructions for fast Kubeflow setup using MicroK8s
|
Hi @ammarn911. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @aronchick |
|
@carmine How's it going with finding a review for this PR? |
| ``` | ||
| $ git clone https://github.com/canonical-labs/kubernetes-tools | ||
| $ sudo kubernetes-tools/setup-microk8s.sh | ||
| $ snap install microk8s --classic --channel=1.17/stable |
There was a problem hiding this comment.
Remove the $ signs in front of the commands, here and below. (It's the standard in the Kubeflow docs to show the commands without the dollar sign, as the dollar may be confusing.)
There was a problem hiding this comment.
@sarahmaddox It might best to specify the channel as 1.15 as this is listed on https://www.kubeflow.org/docs/started/k8s/overview/ as being the latest currently supported version. I didn't realise a bigger refresh of the instructions was underway, before opening a PR addressing the same thing here: #1519
There was a problem hiding this comment.
Thanks @ofaz!
@ammarn911 Please do incorporate this change into your PR as well.
There was a problem hiding this comment.
The version (channel) should be 1.14 not 1.15 as in the first comment in this thread. I've approved PR #1519 which updates the doc to specify channel 1.14.
There was a problem hiding this comment.
It looks to me as though this PR will overwrite the previous PR which set the channel to 1.14. Please would you set the channel specifically in this PR too, just to ensure it doesn't overwrite the previous one. Apart from that, this LGTM. Thanks for persevering with this change!
There was a problem hiding this comment.
@ammarn911 could you explain how you tested MicroK8s with K8s 1.17? Last I checked there were still problems with our kustomize manifests kubeflow/manifests#375
Could you provide some verification that it is working? e.g. can your provide the output of
kubectl -n kubeflow get applications
kubectl -n kubeflow get deploy
I'd like to verify that Kubeflow is correctly deploying on 1.17.
Do we have an issue tracking adding continuous integration for Kubeflow on MicroK8s?
There was a problem hiding this comment.
@jlewi: MicroK8s is deploying with Juju instead of Kustomize, so not running into the 1.16 issues. The microk8s repo itself has some CI running for microk8s.enable kubeflow, if that's what you mean
There was a problem hiding this comment.
@jlewi, @sarahmaddox please let me know if there's anything else
There was a problem hiding this comment.
@knkski @ammarn911 It might make sense to discuss this at a community meeting. Agenda is at http://bit.ly/kf-meeting-notes you should be able to comment to add it for an upcoming agenda.
I think my question is do we have a process (and or owners) for ensuring that Kubeflow on multi-pass is tested and "conformant" ? If not; how should we convey this in the docs?
If MicroK8s isn't using the application manifests in kubeflow/manifests; then that suggests all of the manifests in https://github.com/kubeflow/manifests for individual applications need to be ported to Juju. Is that really what you meant? That seems like a fairly large ongoing maintenance cost. Is that really what's happening and if so what's the plan for keeping them updated?
Looking at kubeflow/manifests#375 e.g.
kubeflow/manifests#375 (comment)
It looks like many of the issues are that the spec for K8s resources changed in 1.16 and therefore various manifests need to be updated. So kustomize is a big orthogonal. Perhaps you aren't hitting these issues simply because you aren't installing the applications causing problems?
One way to avoid blocking this PR would be to include a banner at the top of the page indicating "Alpha support" like the one we have on upgrading deployments
https://www.kubeflow.org/docs/upgrading/upgrade/
We can then figure out what is needed in order to feel confident that we can remove the banner.
There was a problem hiding this comment.
Hey @jlewi, definitely makes sense to discuss in the community meeting, we'll take it there.
In the meantime, I added the Alpha Support banner to roll out the PR and update related docs.
content/docs/other-guides/virtual-dev/getting-started-multipass.md
Outdated
Show resolved
Hide resolved
content/docs/other-guides/virtual-dev/getting-started-multipass.md
Outdated
Show resolved
Hide resolved
content/docs/other-guides/virtual-dev/getting-started-multipass.md
Outdated
Show resolved
Hide resolved
content/docs/other-guides/virtual-dev/getting-started-multipass.md
Outdated
Show resolved
Hide resolved
|
Hallo @ammarn911 Thank you for suggesting this much-needed update! I've tested the instructions on a Debian machine, and have suggested some changes to improve readability. I've also asked a question, as I ran into problems in the "enable Kubeflow" step. @carmine If you have time to take a look that'd be excellent. If not, I'll approve this PR once I get the workflow working on my machine. That means I won't have tested the Multipass side of things. |
|
Fixes #1113 |
|
Hey @sarahmaddox , thank you for reviewing! Looking into the issue, will update with a fix and resolve your comments. |
Updating getting started with Kubeflow doc to address Sarah's comments.
|
Hallo @ammarn911 while you're busy on this page, please would you take a look at the following page which also mentions Microk8s. I think it needs some adjustment too:
|
Hey @sarahmaddox , I'll open a PR to point it to this doc once it is live. Thank you for recommending! |
Adding an "Alpha Support" banner
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating instructions for fast Kubeflow setup using MicroK8s
This change is