-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Microk8s install to specify K8s version #1519
Conversation
Current installation instructions will install (at the time of writing) k8s v1.17 - which is listed on https://www.kubeflow.org/docs/started/k8s/overview/ as being an incompatible version. Specifying the installation channel ensures the user installs a version that Kubeflow is verified against. These instructions will need to be updated as Kubeflow supports newer versions of K8s.
Hi @ofaz. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -19,7 +19,7 @@ GCP, AWS and Azure. | |||
[snapd](https://snapcraft.io/docs/getting-started), which is pre-installed on Ubuntu | |||
and Ubuntu derivative operating systems. | |||
|
|||
1. Install MicroK8s - `snap install microk8s --classic` | |||
1. Install MicroK8s - `snap install microk8s --classic --channel=1.15/stable` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Kubeflow doc, we should install K8s 1.14. Does channel 1.15 install K8s 1.14? That's confusing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahmaddox Apologies - yes you're correct if we're wanting to ensure compatibility with Kubeflow 0.4 as well. I was focussing on ensure that the latest release (at present 0.7) is supported. Shall I amend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the statement from the docs of "The recommended Kubernetes version is 1.14. Kubeflow has been validated and tested on Kubernetes 1.14." I have updated to specify 1.14 when installing Microk8s. Hopefully should prevent any installation woes!
/assign |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Current installation instructions will install (at the time of writing) k8s v1.17 - which is listed on https://www.kubeflow.org/docs/started/k8s/overview/ as being an incompatible version. Specifying the installation channel ensures the user installs a version that Kubeflow is verified against.
These instructions will need to be updated as Kubeflow supports newer versions of K8s.
This change is