-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the CSIMigration API #1107
Add the CSIMigration API #1107
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: b87f43a22096b44e8e5ca4af558e11aac7481131
|
New changes are detected. LGTM label has been removed. |
/retest |
We've discussed internally and decided to rework the API to be a bit more user-friendly, as well as, easier to implement and maintain. I'm going to close this PR and create a new one once the new API is ready. The issue with the CloudProvider field being overridden if Terraform is used has been moved to and merged as part of #1108. /close |
@xmudrii: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Extend the v1beta1 CloudProvider-specific structs to include fields for controlling CSIMigration. For most providers, there are two fields:
This PR includes only the API. The logic that enables the feature gates will be done in a follow-up.
/hold
Validation is missing
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Releavant to #616
Does this PR introduce a user-facing change?:
/assign @kron4eg
/kind api-change