Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CSIMigration API #1107

Closed
wants to merge 3 commits into from
Closed

Add the CSIMigration API #1107

wants to merge 3 commits into from

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 22, 2020

What this PR does / why we need it:

Extend the v1beta1 CloudProvider-specific structs to include fields for controlling CSIMigration. For most providers, there are two fields:

  • CSIMigration - used to enable CSIMigration and CSIMigration{Provider} feature gates on all relevant components
  • CSIMigrationComplete - used to enable the appropriate CSIMigration{Provider}Complete feature gate. Requires CSIMigration to be enabled. This feature flag disables fallback to in-tree volume plugins and should be enabled only after deploying CSI driver to all nodes and ensuring it works correctly.

This PR includes only the API. The logic that enables the feature gates will be done in a follow-up.

/hold
Validation is missing

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Releavant to #616

Does this PR introduce a user-facing change?:

Add API fields used to enable the CSIMigration

/assign @kron4eg
/kind api-change

@xmudrii xmudrii requested a review from kron4eg September 22, 2020 09:47
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b87f43a22096b44e8e5ca4af558e11aac7481131

@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Sep 22, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Sep 22, 2020

We've discussed internally and decided to rework the API to be a bit more user-friendly, as well as, easier to implement and maintain. I'm going to close this PR and create a new one once the new API is ready.

The issue with the CloudProvider field being overridden if Terraform is used has been moved to and merged as part of #1108.

/close

@kubermatic-bot
Copy link
Contributor

@xmudrii: Closed this PR.

In response to this:

We've discussed internally and decided to rework the API to be a bit more user-friendly, as well as, easier to implement and maintain. I'm going to close this PR and create a new one once the new API is ready.

The issue with the CloudProvider field being overridden if Terraform is used has been moved to and merged as part of #1108.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants