Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CSIMigration and CSIMigrationComplete fields to the API #1109

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 22, 2020

What this PR does / why we need it:

This PR adds the following fields to the v1beta1 API:

  • CSIMigration (csiMigration) - enables CSIMigration and CSIMigration{Provider} feature flags on the API server, kube-controller-manager, and kubelets for providers that support the CSI migration
    • On Azure clusters, both CSIMigrationAzureDisk and CSIMigrationAzureFile feature gates are enabled
  • CSIMigrationComplete (csiMigrationComplete) - enables the CSIMigration{Provider}Complete feature gate for providers that support the CSI migration. Enabling this feature disables fallback to the in-tree volume plugins.
    • On Azure clusters, both CSIMigrationAzureDiskComplete and CSIMigrationAzureFileComplete feature gates are enabled
    • You need to ensure that you have deployed the CSI driver on all nodes in a cluster before enabling this feature

This PR only adds the API fields. The code to enable the appropriate feature gates will be added in a follow-up PR.

This PR also adds a validation rule to ensure that CSIMigration is enabled if CSIMigrationComplete is enabled. The full config manifest has been updated to include those two fields and the appropriate descriptions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relevant to #616
Supersedes #1107

Does this PR introduce a user-facing change?:

Add the CSIMigration and CSIMigrationComplete fields to the API

/assign @kron4eg
/kind feature api-change

@xmudrii xmudrii requested a review from kron4eg September 22, 2020 21:22
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 22, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf9b9fe0fabcaaefaeffcd7777a37c89d2c0cd63

@kubermatic-bot kubermatic-bot merged commit 669938d into master Sep 23, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Sep 23, 2020
@kubermatic-bot kubermatic-bot deleted the csi-migration branch September 23, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants