Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Multiarch Image support #67

Closed
wants to merge 9 commits into from
Closed

[WIP] Multiarch Image support #67

wants to merge 9 commits into from

Conversation

vitt-bagal
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
As a continuation to PR and comment Adding this PR to check whether buildx is supported in Prow.

Special notes for your reviewer:
@pohly Could you please have a look ?
Currently the build will fail as quay.io does not support multiarch images.

@k8s-ci-robot
Copy link
Contributor

@vitt-bagal: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @vitt-bagal!

It looks like this is your first PR to kubernetes-csi/node-driver-registrar 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/node-driver-registrar has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vitt-bagal. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitt-bagal
To complete the pull request process, please assign vladimirvivien
You can assign the PR to them by writing /assign @vladimirvivien in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2020
@vitt-bagal
Copy link
Contributor Author

/check-cla

1 similar comment
@vitt-bagal
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 6, 2020
@pohly
Copy link
Contributor

pohly commented Mar 6, 2020

/ok-to-test

We can test it on regular Prow, but it looks like where we really need to run it is in some other job (see kubernetes/test-infra#13332 and https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md).

For testing that (cross-)compilation works, that should be covered by kubernetes-csi/csi-release-tools#76

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2020
@vitt-bagal
Copy link
Contributor Author

@pohly As seen in prow job output docker buildx related commands are giving errors. Since buildx was introduced in docker v19.03. could you please confirm what is the current docker being used in prow setup ?

@pohly
Copy link
Contributor

pohly commented Mar 9, 2020

As seen in prow job output docker buildx related commands are giving errors. Since buildx was introduced in docker v19.03. could you please confirm what is the current docker being used in prow setup ?

The jobs use an image that gets refreshed from time to time. At the moment it is gcr.io/k8s-testimages/kubekins-e2e:v20200306-3e08456-master which contains 19.03.6.

Note that the error wasn't about docker buildx, it was about the --use flag. Are you sure that it is a valid flag in this context?

@vitt-bagal
Copy link
Contributor Author

vitt-bagal commented Mar 11, 2020 •
edited
Loading

--use flag was not identified earlier as DOCKER_CLI_EXPERIMENTAL was not exported properly. I have managed to resolve the issue.
However further encountered error on line wherein $(IMAGE_TAGS) variable was empty (may be because this is PR ?)
so added latest commit to run docker buildx command outside the loop and buildx command was executed.
please check logs
The multiarch image seems to be created however it fails at final push step to quay.io due to lack of access.
What would be the next step as per you ?

@pohly
Copy link
Contributor

pohly commented Mar 11, 2020

What would be the next step as per you ?

We need to move onto the official Kubernetes infrastructure for publishing images (kubernetes/test-infra#13332). Then we can test whether "docker buildx" works there and tentatively push canary images to gcr.io/k8s-staging-csi for further manual testing. Once all of that works, we can plan for switching over officially from quay.io to gcr.io/k8s.

There's also a KEP (https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190204-kubernetes-csi-release-process.md) which needs to be updated; when it was written, a lot about how the Kubernetes image publishing infrastructure might work was still unknown and/or unavailable.

@vitt-bagal
Copy link
Contributor Author

As per your above comment

To confirm that buildx works in test-infra (rather than adding new target in release tools and waiting for the merge) I can think of below solution for a quick check:

It can be achieved with below files:

  1. cloudbuild.yml and dockerfile.multiarch in node-driver-registrar
    cloudbuild.yml.txt
    Dockerfile.multiarch.txt
  2. k8s-staging-csi.yaml in test-infra
    k8s-staging-csi.yaml.txt

Could you please review these files ?
However for this approach to work the above files(1.) need to first get merged in node-driver-registrar.
Is it okay to open PR for the same ?

@pohly
Copy link
Contributor

pohly commented Mar 17, 2020

k8s-staging-csi.yaml.txt

Currently this only enables pushing of versioned images from the "master" branch. We also want to push images from release branches and push the "canary" images that get built from master.

However for this approach to work the above files(1.) need to first get merged in node-driver-registrar. Is it okay to open PR for the same ?

That is because the files have to be in a branch of the repo itself, right?

I suppose it won't hurt to tentatively merge them into "master". It's simpler than creating a dedicated test branch and merging into that. @msau42, what do you think?

cloudbuild.yml.txt:
docker run --rm --privileged linuxkit/binfmt:v0.7

Hmmm. This looks like it'll reconfigure the host on which the Prow job runs? This is probably not going to be acceptable by the Prow maintainers. Also remember that this particular cluster is running highly sensitive jobs - I suppose --privileged will be disallowed for that reason alone. Can we try without that line and if the hosts need to be reconfigured, engage with the Prow admins to get that changed for us?

@vitt-bagal
Copy link
Contributor Author

Currently this only enables pushing of versioned images from the "master" branch. We also want to push images from release branches and push the "canary" images that get built from master.

Yes. As we are testing whether buildx works fine in test-infra. If it works fine then we can modify staging prow job accordingly.

That is because the files have to be in a branch of the repo itself, right?

Yes.

Can we try without that line(docker run --rm --privileged linuxkit/binfmt:v0.7)

I added a commit to remove it and job gives same output. Since we are using multi-stage builds in Dockerfiles to build binaries for different platform, it seems like that command is not needed.

@vitt-bagal
Copy link
Contributor Author

@pohly @msau42 Could you please guide us with next steps?

@pohly
Copy link
Contributor

pohly commented Mar 23, 2020

I suppose it won't hurt to tentatively merge them into "master". It's simpler than creating a dedicated test branch and merging into that. @msau42, what do you think?

We discussed this today and concluded that adding additional files to node-driver-registrar is fine. @vitt-bagal, can you prepare a PR with cloudbuild.yml.txt, Dockerfile.multiarch.txt, k8s-staging-csi.yaml?

@k8s-ci-robot
Copy link
Contributor

@vitt-bagal: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-node-driver-registrar-1-15-on-kubernetes-1-15 ac64fa1 link /test pull-kubernetes-csi-node-driver-registrar-1-15-on-kubernetes-1-15
pull-kubernetes-csi-node-driver-registrar-unit ac64fa1 link /test pull-kubernetes-csi-node-driver-registrar-unit
pull-kubernetes-csi-node-driver-registrar-1-16-on-kubernetes-1-16 ac64fa1 link /test pull-kubernetes-csi-node-driver-registrar-1-16-on-kubernetes-1-16
pull-kubernetes-csi-node-driver-registrar-1-17-on-kubernetes-1-17 ac64fa1 link /test pull-kubernetes-csi-node-driver-registrar-1-17-on-kubernetes-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vitt-bagal vitt-bagal mentioned this pull request Mar 24, 2020
Merged
@vitt-bagal
Copy link
Contributor Author

can you prepare a PR with cloudbuild.yml.txt, Dockerfile.multiarch.txt, k8s-staging-csi.yaml?

Thank you @pohly , raised PR. Will raise in test-infra for prow config job(k8s-staging-csi.yaml) once this is merged in master.

@vitt-bagal vitt-bagal mentioned this pull request Mar 25, 2020
Merged
msau42 pushed a commit to msau42/node-driver-registrar that referenced this pull request Mar 31, 2020
@k8s-ci-robot
Merge pull request kubernetes-csi#67 from windayski/fix-link
3c34b4f 
fix incorrect link
@vitt-bagal
Copy link
Contributor Author

@pohly Looking at Jobs, It seems that image push job of node driver registrar is not running. Can you please take a look ?
Please let me know if i missed something ?

@pohly
Copy link
Contributor

pohly commented Apr 6, 2020

It seems that image push job of node driver registrar is not running. Can you please take a look? Please let me know if i missed something?

Sorry, no idea, and I don't have access to the build cluster, so I can't check.

Can you ask on #wg-k8s-infra? They might be able to help.

@k8s-ci-robot
Copy link
Contributor

@vitt-bagal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2020
@vitt-bagal
Copy link
Contributor Author

closing this as it has been completed via other PRs

@vitt-bagal vitt-bagal closed this Jun 5, 2020
pohly added a commit to pohly/node-driver-registrar that referenced this pull request Oct 12, 2020
@pohly
Squashed 'release-tools/' changes from 3041b8a..a0f195cc
fcc5b4f 
a0f195cc Merge pull request kubernetes-csi#106 from msau42/fix-canary
7100c120 Only set staging registry when running canary job
b3c65f9c Merge pull request kubernetes-csi#99 from msau42/add-release-process
e53f3e85 Merge pull request kubernetes-csi#103 from msau42/fix-canary
d1294628 Document new method for adding CI jobs are new K8s versions
e73c2ce5 Use staging registry for canary tests
2c098465 Add cleanup instructions to release-notes generation
60e1cd3 Merge pull request kubernetes-csi#98 from pohly/kubernetes-1-19-fixes
0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18
3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0
1fbb636 Merge pull request kubernetes-csi#97 from pohly/go-1.15
82d108a switch to Go 1.15
d8a2530 Merge pull request kubernetes-csi#95 from msau42/add-release-process
843bddc Add steps on promoting release images
0345a83 Merge pull request kubernetes-csi#94 from linux-on-ibm-z/bump-timeout
1fdf2d5 cloud build: bump timeout in Prow job
41ec6d1 Merge pull request kubernetes-csi#93 from animeshk08/patch-1
5a54e67 filter-junit: Fix gofmt error
0676fcb Merge pull request kubernetes-csi#92 from animeshk08/patch-1
36ea4ff filter-junit: Fix golint error
f5a4203 Merge pull request kubernetes-csi#91 from cyb70289/arm64
43e50d6 prow.sh: enable building arm64 image
0d5bd84 Merge pull request kubernetes-csi#90 from pohly/k8s-staging-sig-storage
3df86b7 cloud build: k8s-staging-sig-storage
c5fd961 Merge pull request kubernetes-csi#89 from pohly/cloud-build-binfmt
db0c2a7 cloud build: initialize support for running commands in Dockerfile
be902f4 Merge pull request kubernetes-csi#88 from pohly/multiarch-windows-fix
340e082 build.make: optional inclusion of Windows in multiarch images
5231f05 build.make: properly declare push-multiarch
4569f27 build.make: fix push-multiarch ambiguity
17dde9e Merge pull request kubernetes-csi#87 from pohly/cloud-build
bd41690 cloud build: initial set of shared files
9084fec Merge pull request kubernetes-csi#81 from msau42/add-release-process
6f2322e Update patch release notes generation command
0fcc3b1 Merge pull request kubernetes-csi#78 from ggriffiths/fix_csi_snapshotter_rbac_version_set
d8c76fe Support local snapshot RBAC for pull jobs
c1bdf5b Merge pull request kubernetes-csi#80 from msau42/add-release-process
ea1f94a update release tools instructions
152396e Merge pull request kubernetes-csi#77 from ggriffiths/snapshotter201_update
7edc146 Update snapshotter to version 2.0.1
4cf843f Merge pull request kubernetes-csi#76 from pohly/build-targets
3863a0f build for multiple platforms only in CI, add s390x
8322a7d Merge pull request kubernetes-csi#72 from pohly/hostpath-update
7c5a89c prow.sh: use 1.3.0 hostpath driver for testing
b8587b2 Merge pull request kubernetes-csi#71 from wozniakjan/test-vet
fdb3218 Change 'make test-vet' to call 'go vet'
d717c8c Merge pull request kubernetes-csi#69 from pohly/test-driver-config
a1432bc Merge pull request kubernetes-csi#70 from pohly/kubelet-feature-gates
5f74333 prow.sh: also configure feature gates for kubelet
84f78b1 prow.sh: generic driver installation
3c34b4f Merge pull request kubernetes-csi#67 from windayski/fix-link
fa90abd fix incorrect link
ff3cc3f Merge pull request kubernetes-csi#54 from msau42/add-release-process
ac8a021 Document the process for releasing a new sidecar
23be652 Merge pull request kubernetes-csi#65 from msau42/update-hostpath
6582f2f Update hostpath driver version to get fix for connection-timeout
4cc9174 Merge pull request kubernetes-csi#64 from ggriffiths/snapshotter_2_version_update
8191eab Update snapshotter to version v2.0.0
3c463fb Merge pull request kubernetes-csi#61 from msau42/enable-snapshots
8b0316c Fix overriding of junit results by using unique names for each e2e run
5f444b8 Merge pull request kubernetes-csi#60 from saad-ali/updateHostpathVersion
af9549b Update prow hostpath driver version to 1.3.0-rc2
f6c74b3 Merge pull request kubernetes-csi#57 from ggriffiths/version_gt_kubernetes_fix
fc80975 Fix version_gt to work with kubernetes prefix
9f1f3dd Merge pull request kubernetes-csi#56 from msau42/enable-snapshots
b98b2ae Enable snapshot tests in 1.17 to be run in non-alpha jobs.
9ace020 Merge pull request kubernetes-csi#52 from msau42/update-readme
540599b Merge pull request kubernetes-csi#53 from msau42/fix-make
a4e6299 fix syntax for ppc64le build
771ca6f Merge pull request kubernetes-csi#49 from ggriffiths/prowsh_improve_version_gt
d7c69d2 Merge pull request kubernetes-csi#51 from msau42/enable-multinode
4ad6949 Improve snapshot pod running checks and improve version_gt
53888ae Improve README by adding an explicit Kubernetes dependency section
9a7a685 Create a kind cluster with two worker nodes so that the topology feature can be tested. Test cases that test accessing volumes from multiple nodes need to be skipped
4ff2f5f Merge pull request kubernetes-csi#50 from darkowlzz/kind-0.6.0
80bba1f Use kind v0.6.0
6d674a7 Merge pull request kubernetes-csi#47 from Pensu/multi-arch
8adde49 Merge pull request kubernetes-csi#45 from ggriffiths/snapshot_beta_crds
003c14b Add snapshotter CRDs after cluster setup
a41f386 Merge pull request kubernetes-csi#46 from mucahitkurt/kind-cluster-cleanup
1eaaaa1 Delete kind cluster after tests run.
83a4ef1 Adding build for ppc64le
4fcafec Merge pull request kubernetes-csi#43 from pohly/system-pod-logging
f41c135 prow.sh: also log output of system containers
ee22a9c Merge pull request kubernetes-csi#42 from pohly/use-vendor-dir
8067845 travis.yml: also use vendor directory
23df4ae prow.sh: use vendor directory if available
a53bd4c Merge pull request kubernetes-csi#41 from pohly/go-version
c8a1c4a better handling of Go version
5e773d2 update CI to use Go 1.13.3
f419d74 Merge pull request kubernetes-csi#40 from msau42/add-1.16
e0fde8c Add new variables for 1.16 and remove 1.13
adf00fe Merge pull request kubernetes-csi#36 from msau42/full-clone
f1697d2 Do full git clones in travis. Shallow clones are causing test-subtree errors when the depth is exactly 50.
2c81919 Merge pull request kubernetes-csi#34 from pohly/go-mod-tidy
518d6af Merge pull request kubernetes-csi#35 from ddebroy/winbld2
2d6b3ce Build Windows only for amd64
c1078a6 go-get-kubernetes.sh: automate Kubernetes dependency handling
194289a update Go mod support
0affdf9 Merge pull request kubernetes-csi#33 from gnufied/enable-hostpath-expansion
6208f6a Enable hostpath expansion
6ecaa76 Merge pull request kubernetes-csi#30 from msau42/fix-windows
ea2f1b5 build windows binaries with .exe suffix
2d33550 Merge pull request kubernetes-csi#29 from mucahitkurt/create-2-node-kind-cluster
a8ea8bc create 2-node kind cluster since topology support is added to hostpath driver
df8530d Merge pull request kubernetes-csi#27 from pohly/dep-vendor-check
35ceaed prow.sh: install dep if needed
f85ab5a Merge pull request kubernetes-csi#26 from ddebroy/windows1
9fba09b Add rule for building Windows binaries
0400867 Merge pull request kubernetes-csi#25 from msau42/fix-master-jobs
dc0a5d8 Update kind to v0.5.0
aa85b82 Merge pull request kubernetes-csi#23 from msau42/fix-master-jobs
f46191d Kubernetes master changed the way that releases are tagged, which needed changes to kind. There are 3 changes made to prow.sh:
1cac3af Merge pull request kubernetes-csi#22 from msau42/add-1.15-jobs
0c0dc30 prow.sh: tag master images with a large version number
f4f73ce Merge pull request kubernetes-csi#21 from msau42/add-1.15-jobs
4e31f07 Change default hostpath driver name to hostpath.csi.k8s.io
4b6fa4a Update hostpath version for sidecar testing to v1.2.0-rc2
ecc7918 Update kind to v0.4.0. This requires overriding Kubernetes versions with specific patch versions that kind 0.4.0 supports. Also, feature gate setting is only supported on 1.15+ due to kind.sigs.k8s.io/v1alpha3 and kubeadm.k8s.io/v1beta2 dependencies.
a6f21d4 Add variables for 1.15
db8abb6 Merge pull request kubernetes-csi#20 from pohly/test-driver-config
b2f4e05 prow.sh: flexible test driver config
0399988 Merge pull request kubernetes-csi#19 from pohly/go-mod-vendor
066143d build.make: allow repos to use 'go mod' for vendoring
0bee749 Merge pull request kubernetes-csi#18 from pohly/go-version
e157b6b update to Go 1.12.4
88dc9a4 Merge pull request kubernetes-csi#17 from pohly/prow
0fafc66 prow.sh: skip sanity testing if component doesn't support it
bcac1c1 Merge pull request kubernetes-csi#16 from pohly/prow
0b10f6a prow.sh: update csi-driver-host-path
0c2677e Merge pull request kubernetes-csi#15 from pengzhisun/master
ff9bce4 Replace 'return' to 'exit' to fix shellcheck error
c60f382 Merge pull request kubernetes-csi#14 from pohly/prow
7aaac22 prow.sh: remove AllAlpha=all, part II
6617773 Merge pull request kubernetes-csi#13 from pohly/prow
cda2fc5 prow.sh: avoid AllAlpha=true
546d550 prow.sh: debug failing KinD cluster creation
9b0d9cd build.make: skip shellcheck if Docker is not available
aa45a1c prow.sh: more efficient execution of individual tests
f3d1d2d prow.sh: fix hostpath driver version check
31dfaf3 prow.sh: fix running of just "alpha" tests
f501443 prow.sh: AllAlpha=true for unknown Kubernetes versions
95ae9de Merge pull request kubernetes-csi#9 from pohly/prow
d87eccb prow.sh: switch back to upstream csi-driver-host-path
6602d38 prow.sh: different E2E suite depending on Kubernetes version
741319b prow.sh: improve building Kubernetes from source
29545bb prow.sh: take Go version from Kubernetes source
429581c prow.sh: pull Go version from travis.yml
0a0fd49 prow.sh: comment clarification
2069a0a Merge pull request kubernetes-csi#11 from pohly/verify-shellcheck
55212ff initial Prow test job
6c7ba1b build.make: integrate shellcheck into "make test"
b2d25d4 verify-shellcheck.sh: make it usable in csi-release-tools
3b6af7b Merge pull request kubernetes-csi#12 from pohly/local-e2e-suite
104a1ac build.make: avoid unit-testing E2E test suite
34010e7 Merge pull request kubernetes-csi#10 from pohly/vendor-check
e6db50d check vendor directory
fb13c51 verify-shellcheck.sh: import from Kubernetes
94fc1e3 build.make: avoid unit-testing E2E test suite
849db0a Merge pull request kubernetes-csi#8 from pohly/subtree-check-relax
cc564f9 verify-subtree.sh: relax check and ignore old content
33d58fd Merge pull request kubernetes-csi#5 from pohly/test-enhancements
be8a440 Merge pull request kubernetes-csi#4 from pohly/canary-fix
b0336b5 build.make: more readable "make test" output
09436b9 build.make: fix pushing of "canary" image from master branch
147892c build.make: support suppressing checks
154e33d build.make: clarify usage of "make V=1"

git-subtree-dir: release-tools
git-subtree-split: a0f195cc2ddc2a1f07d4d3e46fc08187db358f94
@pohly pohly mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@sbezverk sbezverk Awaiting requested review from sbezverk

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitt-bagal @k8s-ci-robot @pohly