Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiarch Docker Image support using GCB #68

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Multiarch Docker Image support using GCB #68

merged 3 commits into from
Mar 27, 2020

Conversation

vitt-bagal
Copy link
Contributor

@vitt-bagal vitt-bagal commented Mar 24, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
This is continuation with comment #67 (comment)
Add a GCB(Google Cloud Build) configuration file and Dockerfile.multiarch. This will automate the building and pushing of node-driver-registrar multiarch image to staging area(gcr.io/k8s-staging-csi)

@pohly can you please review ?

@vitt-bagal
Add multiarch dockerfile
fb5e53a 
build multiarch image with all arch specified by `--platform` option to docker buildx build
@vitt-bagal
Automate Container Image Builds Using GCB
0c60f8e 
Adding a GCB(Google Cloud Build) config file to automate build and push(to staging gcr.io/k8s-staging-csi) of multiarch docker image
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @vitt-bagal. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2020
@vitt-bagal vitt-bagal mentioned this pull request Mar 24, 2020
Closed
pohly
pohly approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still several open questions (selection of Go release for building, version number), but let's move forward now as we are still experimenting.

/lgtm

cloudbuild.yaml Outdated
@@ -0,0 +1,28 @@
# See https://cloud.google.com/cloud-build/docs/build-config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md would be useful, because that is where it is specified how this works in Kubernetes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the link.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@pohly
Copy link
Contributor

pohly commented Mar 24, 2020

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2020
@pohly
Copy link
Contributor

pohly commented Mar 24, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@vitt-bagal
Copy link
Contributor Author

@pohly Thank you for the review. Addition of latest commit removed the lgtm

pohly
pohly approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@vitt-bagal vitt-bagal mentioned this pull request Mar 25, 2020
Merged
@vitt-bagal
Copy link
Contributor Author

@pohly Can you please help by merging this as this is needed for kubernetes/test-infra#16942

@pohly
Copy link
Contributor

pohly commented Mar 27, 2020

@pohly Can you please help by merging this as this is needed for kubernetes/test-infra#16942

I can't approve in this repo.

/assign @msau42

@pohly pohly removed their assignment Mar 27, 2020
@msau42
Copy link
Collaborator

msau42 commented Mar 27, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, vitt-bagal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6e168e6 into kubernetes-csi:master Mar 27, 2020
@pohly pohly mentioned this pull request May 19, 2020
Closed
@jamesorlakin jamesorlakin mentioned this pull request May 19, 2020
Closed
dobsonj pushed a commit to dobsonj/node-driver-registrar that referenced this pull request Mar 8, 2024
@openshift-merge-bot
Merge pull request kubernetes-csi#68 from dobsonj/OCPBUGS-29987
b159372 
OCPBUGS-29987: Updating csi-node-driver-registrar-container image to be consistent with ART for 4.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitt-bagal @k8s-ci-robot @pohly @msau42