✨ Add HasOwnerReference #2882
✨ Add HasOwnerReference #2882
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| // HasOwnerReference returns true if the owners list contains an owner reference | ||
| // that matches the object's group, kind, and name. | ||
| func HasOwnerReference(owners []metav1.OwnerReference, obj client.Object) bool { | ||
| gvk := obj.GetObjectKind().GroupVersionKind() |
There was a problem hiding this comment.
Can we use the indexOwnerRefs function?
| // HasOwnerReference returns true if the owners list contains an owner reference | ||
| // that matches the object's group, kind, and name. | ||
| func HasOwnerReference(owners []metav1.OwnerReference, obj client.Object) bool { | ||
| gvk := obj.GetObjectKind().GroupVersionKind() |
There was a problem hiding this comment.
There is a function apiutil.GVKForObject() that would be useful here. You would have to interface assert this to a runtime object.
There was a problem hiding this comment.
+1, TypeMeta may not always exist in the object, even c-r has made some workaround for it
kubernetes/kubernetes#3030
kubernetes/kubernetes#80609
There was a problem hiding this comment.
I rewrote like this.
Is it right, I want the feedback, thanks.
| @@ -181,6 +181,18 @@ func HasControllerReference(object metav1.Object) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // HasOwnerReference returns true if the owners list contains an owner reference | |||
| // that matches the object's group, kind, and name. | |||
| func HasOwnerReference(owners []metav1.OwnerReference, obj client.Object) bool { | |||
| func HasOwnerReference(ownerRefs []metav1.OwnerReference, obj client.Object, scheme *runtime.Scheme) bool { | ||
| gvk, err := apiutil.GVKForObject(obj, scheme) | ||
| if err != nil { | ||
| return false |
There was a problem hiding this comment.
Can we return an error here, please?
| Kind: gvk.Kind, | ||
| }) | ||
| return idx != -1 | ||
| } |
k8s-ci-robot
added
size/M
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
feat-has-owner-ref
branch
from
c5352f7 to
5aa3f3e
Compare
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
feat-has-owner-ref
branch
from
f564288 to
1d21e60
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ae6367949e7c936c29310b0ae647b95ad701c775
|
|
please squash commits |
alvaroaleman
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sivchari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I added HasOwnerReference API. This API check if owners contains specific owner.