This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: Remove need for insecure registry #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
makkes
suggested changes
Oct 20, 2020
jimmidyson
force-pushed
the
jimmi/remove-insecure-registry
branch
from
daebfd4 to
6e53857
Compare
|
@makkes Done. |
jimmidyson
force-pushed
the
jimmi/remove-insecure-registry
branch
from
6e53857 to
9eb8b52
Compare
makkes
reviewed
Oct 20, 2020
jimmidyson
force-pushed
the
jimmi/remove-insecure-registry
branch
2 times, most recently
from
9ad08dd to
a05bbaa
Compare
makkes
approved these changes
Oct 21, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jimmidyson
force-pushed
the
jimmi/remove-insecure-registry
branch
from
a05bbaa to
a6e6d4e
Compare
|
/lgtm |
makkes
pushed a commit
to makkes/kubefed
that referenced
this pull request
Oct 22, 2020
After kubernetes-retired#1306 has been merged, `make deploy.kind` broke because it doesn't provide the `KIND_CLUSTER_NAME` variable. An empty default provided to `kind`'s `--name` parameter doesn't make much sense because `kind` will simply error out in that case so using a default of `kind` for the name is the solution that should work most of the time, especially when following the quick start guide in the README.md.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the need for the insecure registry deployment and configuration from running e2e tests locally with kind.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #496.
Special notes for your reviewer: