Add additional validation to Volume Snapshot objects

[AndiLi99]

Enhancement Description

• One-line enhancement description (can be used as a release note): Validate immutable fields and add oneOf validation to VolumeSnapshot and VolumeSnapshotContent objects
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md
• Primary contact (assignee): @AndiLi99
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y) 1.20

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[AndiLi99]

/sig storage

[kikisdeliveryservice]

Hi @AndiLi99

Enhancements Lead here. Will this be graduating in 1.20?

Thanks!
Kirsten

[AndiLi99]

Hi!

This feature is targeting 1.20 for GA. cc @msau42

[AndiLi99]

See also #177

[xing-yang]

Hi @kikisdeliveryservice,

This goes together with #177.

Thanks!
Xing

[msau42]

@xing-yang should we combine the 2 enhancements and treat this as a requirement for the snapshots feature?

[xing-yang]

@xing-yang should we combine the 2 enhancements and treat this as a requirement for the snapshots feature?

Yes, that makes sense.

@kikisdeliveryservice, this enhancement is a component of #177. Can we just use 177 to track instead of tracking them separately? Thanks!

[kikisdeliveryservice]

Hi @xing-yang

Just to clarify this issue 1900 (which was going straight to stable) is essentially the GA step (and graduation criteria, etc...) for 177?

Thanks!

[xing-yang]

Just to clarify this issue 1900 (which was going straight to stable) is essentially the GA step (and graduation criteria, etc...) for 177?

Hi @kikisdeliveryservice, this is one important step we need before moving 177 to GA. There are other things that are required before moving to GA and they are tracked already by 177.

Thanks!

[kikisdeliveryservice]

Hi @xing-yang

I gave it some thought and the current setup is confusing and difficult to track.

You put the KEP for this (which uses the old format): https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/tighten-validation-webhook-crd.md in the dir for 177 https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/177-volume-snapshot

Note: the KEP in 177 uses the old format here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/README.md

My suggestion:

• Move the KEP for this into its own dir so it can be properly tracked and use the correct format
• Update the description for 177 with a link to this KEP as a requirement for this one and be very clear that this KEP 1900 needs to be completed. (if you have trouble updating the description, let me know i can help with that)
• Update 177 KEP to use the new format as well including all missing sections.
• Update the graduation criteria for 177 and include this KEP : https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/177-volume-snapshot/README.md#beta-ga

The above would make it very clear that 177 is dependent on this KEP but also allow us to properly track both and have the dirs set up correctly.

Please let me know if you have any questions or need any assistance!! As a note Enhancements Freeze is October 6th.

Best,
Kirsten

[xing-yang]

Hi @kikisdeliveryservice,

Sure, I'll sort out the dir structure following the new format.

Thanks,
Xing

[xing-yang]

Hi @kikisdeliveryservice,

I submitted a PR here to sort out the dir structure for these two enhancement issues:
#1994

Actually the work needed for #1900 will happen out-of-tree, so this can be tracked as tracked/out-of-tree.
While the issue #177 includes in-tree components so that needs to be tracked as tracked/yes.

Will this be more clear?

[kikisdeliveryservice]

It looks great @xing-yang definitely more clear. Thanks for doing this!! 👍 😄

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[annajung]

Hi @xing-yang 1.21 Enhancement Lead here.

I believe this issue can close now with being GA. Before closing, can you update the kep.yaml to reflect a status of implemented:

enhancements/keps/sig-storage/1900-volume-snapshot-validation-webhook/kep.yaml

Line 9 in 35069fd

status: implementable

Once that merges, we can close out this issue.

/remove-lifecycle stale

[xing-yang]

Will do. Thanks @annajung for the reminder.

[annajung]

I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

[k8s-ci-robot]

@annajung: Closing this issue.

In response to this:

I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.