Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snapshot KEP for GA #1994

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update snapshot KEP for GA #1994

merged 1 commit into from
Oct 2, 2020

Conversation

xing-yang
Copy link
Contributor

This PR updates the snapshot KEP to prepare for GA.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 20, 2020
@xing-yang xing-yang force-pushed the snapshot_ga branch 3 times, most recently from ba99336 to ed4137c Compare September 26, 2020 14:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2020
@xing-yang xing-yang changed the title WIP: Update snapshot KEP for GA Update snapshot KEP for GA Sep 26, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2020
@xing-yang
Copy link
Contributor Author

/assign @msau42

@xing-yang xing-yang mentioned this pull request Sep 26, 2020
Closed
@kikisdeliveryservice
Copy link
Member

This PR addresses issues #177 and #1900 (wanted to make sure they both linked back here)

@xing-yang
Copy link
Contributor Author

CC @yuxiangqian

msau42
msau42 reviewed Sep 28, 2020
View reviewed changes
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
@deads2k
Copy link
Contributor

deads2k commented Sep 30, 2020

prr lgtm

/lgtm
/hold

holding in case you'd like additional review. Feel free to remove the hold when appropriate.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2020
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Sep 30, 2020
Closed
@xing-yang
Copy link
Contributor Author

Thanks @deads2k!

@msau42 Addressed your comments. PTAL. Thanks!

msau42
msau42 reviewed Oct 1, 2020
View reviewed changes
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Outdated Show resolved Hide resolved
keps/sig-storage/177-volume-snapshot/README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2020
@xing-yang
Copy link
Contributor Author

@msau42 @yuxiangqian All comments are addressed. PTAL.

@msau42
Copy link
Member

msau42 commented Oct 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xing-yang
Copy link
Contributor Author

@msau42 has approved. Canceling the hold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit eb0150d into kubernetes:master Oct 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@yuxiangqian yuxiangqian yuxiangqian left review comments

@deads2k deads2k deads2k left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@deads2k deads2k

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@xing-yang @kikisdeliveryservice @deads2k @msau42 @k8s-ci-robot @yuxiangqian