Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use boskos' new image repo #1161

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Use boskos' new image repo #1161

merged 1 commit into from
Aug 19, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 19, 2020

Followup to #1160

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and nikhita August 19, 2020 04:01
@BenTheElder
Copy link
Member

/lgtm
/approve
deploy from staging seems legit

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b4e26e3 into kubernetes:master Aug 19, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 19, 2020

deploy from staging seems legit

Yeah I agree, I think we can ask for a promoted image tomorrow if things look better

@spiffxp spiffxp deleted the oh-right-boskos-moved branch August 19, 2020 04:05
@dibyom dibyom mentioned this pull request Aug 19, 2020
Merged
2 tasks
@spiffxp spiffxp added the area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @BenTheElder @k8s-ci-robot