Update boskos images to latest #535
Conversation
tekton-robot
added
the
size/XS
|
Maybe we should hold off on merging till we can use a non staging repo image for this. |
|
/hold Manual deploy seems to be working:
|
tekton-robot
added
the
do-not-merge/hold
|
Nice fix!!! total nit, but is it possible to update the commit message / PR description to explain a bit about why this fixes the problem? /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| @@ -153,7 +153,7 @@ spec: | |||
| terminationGracePeriodSeconds: 30 | |||
| containers: | |||
| - name: boskos | |||
| image: gcr.io/k8s-prow/boskos/boskos:v20200213-a79910c4a | |||
| image: gcr.io/k8s-staging-boskos/boskos:v20200819-984516e | |||
There was a problem hiding this comment.
There's no non-staging repo yet, so this is fine. (It's populated by images that are automatically built on merges, basically exactly the same as gcr.io/k8s-prow/boskos was.)
There will eventually hopefully be tagged releases in k8s.gcr.io/boskos, but we don't have those yet.
The current boskos janitor was failing to clean up projects which seems to be due to GCP adding two new logging sinks that cannot be deleted. The new boskos image fixes this. See kubernetes-sigs/boskos#37 for more details. Fixes tektoncd#534 Signed-off-by: Dibyo Mukherjee <[email protected]>
|
/hold cancel Based on @ixdy 's comment above, we should be fine using the staging repo. |
tekton-robot
removed
the
do-not-merge/hold
|
/lgtm |
afrittoli
added
kind/bug
Changes
The current boskos janitor was failing to clean up projects which seems to be
due to GCP adding two new logging sinks that cannot be deleted. The new boskos
image fixes this. See kubernetes-sigs/boskos#37 for more details.
I'm using the staging GCR like kubernetes/k8s.io#1161 in order to unblock our tests.
Fixes #534
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.